Bug 217008 – Test bug for code review timeouts

• Status: ASSIGNED
• Component: WebGL

[Kenneth Russell]

This is a test bug for diagnosing timeouts with the code review tool when using Chrome - crbug.com/1132508 .

[Kenneth Russell]

Created attachment 409769 [details]
Patch

[Kenneth Russell]

Created attachment 409894 [details]
Patch

[Kenneth Russell]

Created attachment 409895 [details]
Patch

[Kenneth Russell]

Created attachment 409897 [details]
Patch

[Joey Arhar]

Created attachment 409932 [details]
test patch

[Joey Arhar]

Created attachment 409933 [details]
test patch upload 2

[Joey Arhar]

Created attachment 409934 [details]
test patch upload 3

[Joey Arhar]

Comment on attachment 409897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review

> Source/WebCore/ChangeLog:10
> +        * html/canvas/WebGLRenderingContextBase.cpp:

test comment 1

[Joey Arhar]

Comment on attachment 409897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review

> Source/WebCore/ChangeLog:11
> +        (WebCore::WebGLRenderingContextBase::initializeNewContext):

test comment 2

[Joey Arhar]

Comment on attachment 409897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review

> Source/WebCore/ChangeLog:12
> +        (WebCore::WebGLRenderingContextBase::bindAttribLocation):

test comment 3

[Joey Arhar]

Comment on attachment 409897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review

> Source/WebCore/ChangeLog:13
> +        (WebCore::WebGLRenderingContextBase::createFramebuffer):

test comment 4

[Joey Arhar]

Comment on attachment 409897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review

> Source/WebCore/ChangeLog:14
> +        (WebCore::WebGLRenderingContextBase::drawArrays):

test comment 5

[Joey Arhar]

Comment on attachment 409897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review

> Source/WebCore/ChangeLog:15
> +        (WebCore::WebGLRenderingContextBase::getUniformLocation):

test comment 6

[Joey Arhar]

View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review

> Source/WebCore/ChangeLog:15
> +        (WebCore::WebGLRenderingContextBase::getUniformLocation):

test comment 6

[Joey Arhar]

Comment on attachment 409897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review

> Source/WebCore/ChangeLog:16
> +        (WebCore::WebGLRenderingContextBase::readPixels):

test comment 7

[Joey Arhar]

Comment on attachment 409897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review

> Source/WebCore/ChangeLog:17
> +        (WebCore::WebGLRenderingContextBase::texSubImage2DBase):

test comment 8

[Joey Arhar]

Comment on attachment 409897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review

> Source/WebCore/ChangeLog:18
> +        (WebCore::WebGLRenderingContextBase::texParameter):

test comment 9

[Joey Arhar]

Comment on attachment 409897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review

> Source/WebCore/ChangeLog:19
> +

test comment 10

[Joey Arhar]

Comment on attachment 409897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review

> Source/WebCore/ChangeLog:20
>  2020-09-23  Chris Dumez  <[e-mail]>

test comment 11

[Joey Arhar]

Comment on attachment 409897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review

> Source/WebCore/ChangeLog:21
>  

test comment 12

[Joey Arhar]

Comment on attachment 409897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review

> Source/WebCore/ChangeLog:22
>          webaudio/AudioBufferSource/audiobuffersource-playbackrate.html is crashing

test comment 13

[Joey Arhar]

Comment on attachment 409897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:844
>  

test comment 14

[Joey Arhar]

Comment on attachment 409897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:845
>  void WebGLRenderingContextBase::initializeNewContext()

test comment 15

[Joey Arhar]

Comment on attachment 409897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:846
>  {

test comment 16

[Joey Arhar]

Comment on attachment 409897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:847
> +    //

test comment 17

[Joey Arhar]

Comment on attachment 409897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:848
> +    //

test comment 18

[Joey Arhar]

Comment on attachment 409897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:849
> +    // TESTING

test comment 19

[Joey Arhar]

Comment on attachment 409897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:850
> +    //

test comment 20

[Joey Arhar]

Comment on attachment 409897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:851
> +    //

test comment 21

[Joey Arhar]

Comment on attachment 409897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:852
> +

test comment 22

[Joey Arhar]

Comment on attachment 409897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:853
>      ASSERT(!m_contextLost);

test comment 23

[Joey Arhar]

Comment on attachment 409897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:854
>      m_needsUpdate = true;

test comment 24

[Joey Arhar]

Comment on attachment 409897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:855
>      m_markedCanvasDirty = false;

test comment 25

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1349
>  

test comment 26

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1350
>  void WebGLRenderingContextBase::bindAttribLocation(WebGLProgram& program, GCGLuint index, const String& name)

test comment 27

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1351
>  {

test comment 28

[Joey Arhar]

Comment on attachment 409897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1352
> +    //

test comment 29

[Joey Arhar]

Comment on attachment 409932 [details]
test patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409932&action=review

> Source/WebCore/ChangeLog:1
> [phone]  Kenneth Russell  <[e-mail]>

test comment 1

[Joey Arhar]

Comment on attachment 409932 [details]
test patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409932&action=review

> Source/WebCore/ChangeLog:2
> +

test comment 2

[Joey Arhar]

Comment on attachment 409932 [details]
test patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409932&action=review

> Source/WebCore/ChangeLog:3
> +        Test bug for code review timeouts

test comment 3

[Joey Arhar]

Comment on attachment 409932 [details]
test patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409932&action=review

> Source/WebCore/ChangeLog:3
> +        Test bug for code review timeouts

test comment 3

[Joey Arhar]

Comment on attachment 409932 [details]
test patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409932&action=review

> Source/WebCore/ChangeLog:3
> +        Test bug for code review timeouts

test comment 3

[Joey Arhar]

Comment on attachment 409932 [details]
test patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409932&action=review

>>>> Source/WebCore/ChangeLog:3
>>>> +        Test bug for code review timeouts
>>> 
>>> test comment 3
>> 
>> test comment 3
> 
> test comment 3

test comment 3

> Source/WebCore/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=217008

test comment 4

[Joey Arhar]

Comment on attachment 409932 [details]
test patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409932&action=review

>>>>> Source/WebCore/ChangeLog:3
>>>>> +        Test bug for code review timeouts
>>>> 
>>>> test comment 3
>>> 
>>> test comment 3
>> 
>> test comment 3
> 
> test comment 3

test comment 3

[Joey Arhar]

Comment on attachment 409932 [details]
test patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409932&action=review

> Source/WebCore/ChangeLog:7
> +

test comment 5

[Joey Arhar]

Comment on attachment 409932 [details]
test patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409932&action=review

> Source/WebCore/ChangeLog:8
> +        No-op changes to have a place for code reviews.

test comment 6

[Joey Arhar]

Comment on attachment 409932 [details]
test patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409932&action=review

> Source/WebCore/ChangeLog:10
> +        * html/canvas/WebGLRenderingContextBase.cpp:

test comment 7

[Joey Arhar]

Comment on attachment 409932 [details]
test patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409932&action=review

> Source/WebCore/ChangeLog:11
> +        (WebCore::WebGLRenderingContextBase::initializeNewContext):

test comment 8

[Joey Arhar]

Comment on attachment 409932 [details]
test patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409932&action=review

> Source/WebCore/ChangeLog:13
> +        (WebCore::WebGLRenderingContextBase::createFramebuffer):

test comment 9

[Joey Arhar]

Comment on attachment 409932 [details]
test patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409932&action=review

> Source/WebCore/ChangeLog:14
> +        (WebCore::WebGLRenderingContextBase::drawArrays):

test comment 10

[Joey Arhar]

Comment on attachment 409932 [details]
test patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409932&action=review

> Source/WebCore/ChangeLog:16
> +        (WebCore::WebGLRenderingContextBase::readPixels):

test comment 11

[Joey Arhar]

Comment on attachment 409932 [details]
test patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409932&action=review

>> Source/WebCore/ChangeLog:16
>> +        (WebCore::WebGLRenderingContextBase::readPixels):
> 
> test comment 11

test comment 11

[Joey Arhar]

Comment on attachment 409932 [details]
test patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409932&action=review

> Source/WebCore/ChangeLog:18
> +        (WebCore::WebGLRenderingContextBase::texParameter):

test comment 12

[Joey Arhar]

Comment on attachment 409932 [details]
test patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409932&action=review

> Source/WebCore/ChangeLog:19
> +

test comment 13

[Joey Arhar]

Comment on attachment 409932 [details]
test patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409932&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:844
>  

test comment 14

[Joey Arhar]

Comment on attachment 409932 [details]
test patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409932&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:845
>  void WebGLRenderingContextBase::initializeNewContext()

test comment 15

[Joey Arhar]

Comment on attachment 409933 [details]
test patch upload 2

View in context: https://bugs.webkit.org/attachment.cgi?id=409933&action=review

> Source/WebCore/ChangeLog:2
> +

comment 1

[Joey Arhar]

Comment on attachment 409933 [details]
test patch upload 2

View in context: https://bugs.webkit.org/attachment.cgi?id=409933&action=review

> Source/WebCore/ChangeLog:3
> +        Test bug for code review timeouts

comment 2

[Joey Arhar]

Comment on attachment 409933 [details]
test patch upload 2

View in context: https://bugs.webkit.org/attachment.cgi?id=409933&action=review

> Source/WebCore/ChangeLog:5
> +

comment 3

[Joey Arhar]

Comment on attachment 409933 [details]
test patch upload 2

View in context: https://bugs.webkit.org/attachment.cgi?id=409933&action=review

> Source/WebCore/ChangeLog:6
> +        Reviewed by NOBODY (OOPS!).

comment 4

[Joey Arhar]

Comment on attachment 409933 [details]
test patch upload 2

View in context: https://bugs.webkit.org/attachment.cgi?id=409933&action=review

> Source/WebCore/ChangeLog:8
> +        No-op changes to have a place for code reviews.

comment 5

[Joey Arhar]

Comment on attachment 409933 [details]
test patch upload 2

View in context: https://bugs.webkit.org/attachment.cgi?id=409933&action=review

> Source/WebCore/ChangeLog:10
> +        * html/canvas/WebGLRenderingContextBase.cpp:

comment 6

[Joey Arhar]

Comment on attachment 409933 [details]
test patch upload 2

View in context: https://bugs.webkit.org/attachment.cgi?id=409933&action=review

> Source/WebCore/ChangeLog:11
> +        (WebCore::WebGLRenderingContextBase::initializeNewContext):

comment 7

[Joey Arhar]

Comment on attachment 409933 [details]
test patch upload 2

View in context: https://bugs.webkit.org/attachment.cgi?id=409933&action=review

> Source/WebCore/ChangeLog:13
> +        (WebCore::WebGLRenderingContextBase::createFramebuffer):

comment 8

[Joey Arhar]

Comment on attachment 409933 [details]
test patch upload 2

View in context: https://bugs.webkit.org/attachment.cgi?id=409933&action=review

> Source/WebCore/ChangeLog:14
> +        (WebCore::WebGLRenderingContextBase::drawArrays):

comment 9

[Joey Arhar]

Comment on attachment 409933 [details]
test patch upload 2

View in context: https://bugs.webkit.org/attachment.cgi?id=409933&action=review

> Source/WebCore/ChangeLog:16
> +        (WebCore::WebGLRenderingContextBase::readPixels):

comment 10

[Joey Arhar]

Comment on attachment 409933 [details]
test patch upload 2

View in context: https://bugs.webkit.org/attachment.cgi?id=409933&action=review

> Source/WebCore/ChangeLog:17
> +        (WebCore::WebGLRenderingContextBase::texSubImage2DBase):

comment 11

[Joey Arhar]

Comment on attachment 409933 [details]
test patch upload 2

View in context: https://bugs.webkit.org/attachment.cgi?id=409933&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:844
>  

comment 12

[Joey Arhar]

Comment on attachment 409933 [details]
test patch upload 2

View in context: https://bugs.webkit.org/attachment.cgi?id=409933&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:845
>  void WebGLRenderingContextBase::initializeNewContext()

comment 13

[Joey Arhar]

Comment on attachment 409933 [details]
test patch upload 2

View in context: https://bugs.webkit.org/attachment.cgi?id=409933&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:847
> +    //

comment 14

[Joey Arhar]

Comment on attachment 409933 [details]
test patch upload 2

View in context: https://bugs.webkit.org/attachment.cgi?id=409933&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:849
> +    // TESTING

comment 15

[Joey Arhar]

Comment on attachment 409933 [details]
test patch upload 2

View in context: https://bugs.webkit.org/attachment.cgi?id=409933&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:852
> +

comment 16

[Joey Arhar]

Comment on attachment 409933 [details]
test patch upload 2

View in context: https://bugs.webkit.org/attachment.cgi?id=409933&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:853
>      ASSERT(!m_contextLost);

comment 17

[Joey Arhar]

Comment on attachment 409934 [details]
test patch upload 3

View in context: https://bugs.webkit.org/attachment.cgi?id=409934&action=review

> Source/WebCore/ChangeLog:1
> [phone]  Kenneth Russell  <[e-mail]>

comment 1

[Radar WebKit Bug Importer]

<rdar://problem/69907701>

[Joey Arhar]

Created attachment 411001 [details]
test patch 4

[Joey Arhar]

Comment on attachment 411001 [details]
test patch 4

View in context: https://bugs.webkit.org/attachment.cgi?id=411001&action=review

> Source/WebCore/ChangeLog:1
> [phone]  Kenneth Russell  <[e-mail]>

comment 1

[Joey Arhar]

Comment on attachment 411001 [details]
test patch 4

View in context: https://bugs.webkit.org/attachment.cgi?id=411001&action=review

> Source/WebCore/ChangeLog:2
> +

comment 2

[Joey Arhar]

Comment on attachment 411001 [details]
test patch 4

View in context: https://bugs.webkit.org/attachment.cgi?id=411001&action=review

> Source/WebCore/ChangeLog:3
> +        Test bug for code review timeouts

comment 3

[Joey Arhar]

Comment on attachment 411001 [details]
test patch 4

View in context: https://bugs.webkit.org/attachment.cgi?id=411001&action=review

> Source/WebCore/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=217008

comment 4

[Joey Arhar]

Comment on attachment 411001 [details]
test patch 4

View in context: https://bugs.webkit.org/attachment.cgi?id=411001&action=review

> Source/WebCore/ChangeLog:5
> +

5

> Source/WebCore/ChangeLog:6
> +        Reviewed by NOBODY (OOPS!).

6

[Joey Arhar]

Comment on attachment 411001 [details]
test patch 4

View in context: https://bugs.webkit.org/attachment.cgi?id=411001&action=review

> Source/WebCore/ChangeLog:7
> +

7

[Joey Arhar]

Comment on attachment 411001 [details]
test patch 4

View in context: https://bugs.webkit.org/attachment.cgi?id=411001&action=review

> Source/WebCore/ChangeLog:9
> +

9

[Joey Arhar]

Comment on attachment 411001 [details]
test patch 4

View in context: https://bugs.webkit.org/attachment.cgi?id=411001&action=review

> Source/WebCore/ChangeLog:10
> +        * html/canvas/WebGLRenderingContextBase.cpp:

10

[Joey Arhar]

Comment on attachment 411001 [details]
test patch 4

View in context: https://bugs.webkit.org/attachment.cgi?id=411001&action=review

> Source/WebCore/ChangeLog:11
> +        (WebCore::WebGLRenderingContextBase::initializeNewContext):

11

[Joey Arhar]

Comment on attachment 411001 [details]
test patch 4

View in context: https://bugs.webkit.org/attachment.cgi?id=411001&action=review

> Source/WebCore/ChangeLog:12
> +        (WebCore::WebGLRenderingContextBase::bindAttribLocation):

12

[Joey Arhar]

Created attachment 411014 [details]
test

[Joey Arhar]

Comment on attachment 411014 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411014&action=review

> Source/WebCore/ChangeLog:1
> [phone]  Kenneth Russell  <[e-mail]>

1

[Joey Arhar]

Comment on attachment 411014 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411014&action=review

> Source/WebCore/ChangeLog:2
> +

2

[Joey Arhar]

Comment on attachment 411014 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411014&action=review

> Source/WebCore/ChangeLog:3
> +        Test bug for code review timeouts

3

[Joey Arhar]

Comment on attachment 411014 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411014&action=review

> Source/WebCore/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=217008

4

[Joey Arhar]

Comment on attachment 411014 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411014&action=review

> Source/WebCore/ChangeLog:5
> +

5

[Joey Arhar]

Comment on attachment 411014 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411014&action=review

> Source/WebCore/ChangeLog:6
> +        Reviewed by NOBODY (OOPS!).

6

[Joey Arhar]

Comment on attachment 411014 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411014&action=review

> Source/WebCore/ChangeLog:7
> +

7

[Joey Arhar]

Comment on attachment 411014 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411014&action=review

> Source/WebCore/ChangeLog:8
> +        No-op changes to have a place for code reviews.

8

[Joey Arhar]

Comment on attachment 411014 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411014&action=review

> Source/WebCore/ChangeLog:9
> +

9

[Joey Arhar]

Created attachment 411121 [details]
test

[Joey Arhar]

Comment on attachment 411121 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411121&action=review

> Source/WebCore/ChangeLog:1
> [phone]  Kenneth Russell  <[e-mail]>

1

[Joey Arhar]

Comment on attachment 411121 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411121&action=review

> Source/WebCore/ChangeLog:2
> +

2

[Joey Arhar]

Comment on attachment 411121 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411121&action=review

> Source/WebCore/ChangeLog:3
> +        Test bug for code review timeouts

3

[Joey Arhar]

Comment on attachment 411121 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411121&action=review

>> Source/WebCore/ChangeLog:3
>> +        Test bug for code review timeouts
> 
> 3

3

> Source/WebCore/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=217008

4

[Joey Arhar]

Comment on attachment 411121 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411121&action=review

>>> Source/WebCore/ChangeLog:3
>>> +        Test bug for code review timeouts
>> 
>> 3
> 
> 3

3

>> Source/WebCore/ChangeLog:4
>> +        https://bugs.webkit.org/show_bug.cgi?id=217008
> 
> 4

4

> Source/WebCore/ChangeLog:5
> +

5

[Joey Arhar]

Created attachment 411246 [details]
test

[Joey Arhar]

Comment on attachment 411246 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411246&action=review

> Source/WebCore/ChangeLog:1
> [phone]  Kenneth Russell  <[e-mail]>

1

[Joey Arhar]

Comment on attachment 411246 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411246&action=review

> Source/WebCore/ChangeLog:2
> +

2

[Joey Arhar]

Comment on attachment 411246 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411246&action=review

> Source/WebCore/ChangeLog:3
> +        Test bug for code review timeouts

3

[Joey Arhar]

Comment on attachment 411246 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411246&action=review

>> Source/WebCore/ChangeLog:3
>> +        Test bug for code review timeouts
> 
> 3

3

> Source/WebCore/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=217008

4

[Joey Arhar]

Comment on attachment 411246 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411246&action=review

> Source/WebCore/ChangeLog:5
> +

5

[Joey Arhar]

Comment on attachment 411246 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411246&action=review

> Source/WebCore/ChangeLog:6
> +        Reviewed by NOBODY (OOPS!).

6

[Joey Arhar]

Comment on attachment 411246 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411246&action=review

> Source/WebCore/ChangeLog:7
> +

7

[Joey Arhar]

Comment on attachment 411246 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411246&action=review

> Source/WebCore/ChangeLog:8
> +        No-op changes to have a place for code reviews.

8

[Joey Arhar]

Created attachment 411268 [details]
test

[Joey Arhar]

Comment on attachment 411268 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411268&action=review

> Source/WebCore/ChangeLog:1
> [phone]  Kenneth Russell  <[e-mail]>

1

[Joey Arhar]

Comment on attachment 411268 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411268&action=review

> Source/WebCore/ChangeLog:2
> +

2

[Joey Arhar]

Comment on attachment 411268 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411268&action=review

> Source/WebCore/ChangeLog:3
> +        Test bug for code review timeouts

3

[Joey Arhar]

Comment on attachment 411268 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411268&action=review

>> Source/WebCore/ChangeLog:3
>> +        Test bug for code review timeouts
> 
> 3

3

> Source/WebCore/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=217008

4

[Joey Arhar]

Comment on attachment 411268 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411268&action=review

>>> Source/WebCore/ChangeLog:3
>>> +        Test bug for code review timeouts
>> 
>> 3
> 
> 3

3

>> Source/WebCore/ChangeLog:4
>> +        https://bugs.webkit.org/show_bug.cgi?id=217008
> 
> 4

4

> Source/WebCore/ChangeLog:5
> +

5

[Joey Arhar]

Comment on attachment 411268 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411268&action=review

> Source/WebCore/ChangeLog:6
> +        Reviewed by NOBODY (OOPS!).

6

[Joey Arhar]

Comment on attachment 411268 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411268&action=review

> Source/WebCore/ChangeLog:7
> +

7

[Joey Arhar]

Comment on attachment 411268 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411268&action=review

> Source/WebCore/ChangeLog:8
> +        No-op changes to have a place for code reviews.

8

[Joey Arhar]

Created attachment 411277 [details]
test

[Joey Arhar]

Comment on attachment 411277 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411277&action=review

> Source/WebCore/ChangeLog:1
> [phone]  Kenneth Russell  <[e-mail]>

1

[Joey Arhar]

Comment on attachment 411277 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411277&action=review

> Source/WebCore/ChangeLog:2
> +

2

[Joey Arhar]

Comment on attachment 411277 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411277&action=review

> Source/WebCore/ChangeLog:3
> +        Test bug for code review timeouts

3

[Joey Arhar]

Comment on attachment 411277 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411277&action=review

> Source/WebCore/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=217008

4

[Joey Arhar]

Comment on attachment 411277 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411277&action=review

> Source/WebCore/ChangeLog:5
> +

5

[Joey Arhar]

Comment on attachment 411277 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411277&action=review

> Source/WebCore/ChangeLog:6
> +        Reviewed by NOBODY (OOPS!).

6

[Joey Arhar]

Comment on attachment 411277 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411277&action=review

> Source/WebCore/ChangeLog:7
> +

7

[Joey Arhar]

Created attachment 411284 [details]
test

[Joey Arhar]

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/ChangeLog:1
> [phone]  Kenneth Russell  <[e-mail]>

1

[Joey Arhar]

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

>> Source/WebCore/ChangeLog:1
>> [phone]  Kenneth Russell  <[e-mail]>
> 
> 1

1

> Source/WebCore/ChangeLog:2
> +

2

[Joey Arhar]

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/ChangeLog:3
> +        Test bug for code review timeouts

3

[Joey Arhar]

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=217008

4

[Joey Arhar]

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/ChangeLog:5
> +

5

[Joey Arhar]

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/ChangeLog:6
> +        Reviewed by NOBODY (OOPS!).

6

[Joey Arhar]

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/ChangeLog:7
> +

7

[Joey Arhar]

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/ChangeLog:8
> +        No-op changes to have a place for code reviews.

8

[Joey Arhar]

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/ChangeLog:9
> +

9

[Joey Arhar]

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/ChangeLog:10
> +        * html/canvas/WebGLRenderingContextBase.cpp:

10

[Joey Arhar]

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/ChangeLog:11
> +        (WebCore::WebGLRenderingContextBase::initializeNewContext):

11

[Joey Arhar]

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/ChangeLog:12
> +        (WebCore::WebGLRenderingContextBase::bindAttribLocation):

12

[Joey Arhar]

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/ChangeLog:13
> +        (WebCore::WebGLRenderingContextBase::createFramebuffer):

13

[Joey Arhar]

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/ChangeLog:14
> +        (WebCore::WebGLRenderingContextBase::drawArrays):

14

[Joey Arhar]

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/ChangeLog:15
> +        (WebCore::WebGLRenderingContextBase::getUniformLocation):

15

[Joey Arhar]

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/ChangeLog:16
> +        (WebCore::WebGLRenderingContextBase::readPixels):

16

[Joey Arhar]

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/ChangeLog:17
> +        (WebCore::WebGLRenderingContextBase::texSubImage2DBase):

17

[Joey Arhar]

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/ChangeLog:18
> +        (WebCore::WebGLRenderingContextBase::texParameter):

18

[Joey Arhar]

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/ChangeLog:19
> +

19

[Joey Arhar]

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/ChangeLog:20
>  2020-09-23  Chris Dumez  <[e-mail]>

20

[Joey Arhar]

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/ChangeLog:21
>  

21

[Joey Arhar]

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/ChangeLog:22
>          webaudio/AudioBufferSource/audiobuffersource-playbackrate.html is crashing

22

[Joey Arhar]

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:844
>  

23

[Joey Arhar]

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:845
>  void WebGLRenderingContextBase::initializeNewContext()

24

[Joey Arhar]

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:846
>  {

25

[Joey Arhar]

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:847
> +    //

26

[Joey Arhar]

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:848
> +    //

27

[Joey Arhar]

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:849
> +    // TESTING

28

[Joey Arhar]

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:850
> +    //

29

[Joey Arhar]

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:850
>> +    //
> 
> 29

29

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:851
> +    //

30

[Richard Townsend]

Comment on attachment 411284 [details]
test

Testing

[Richard Townsend]

Comment on attachment 411284 [details]
test

Testing

[Richard Townsend]

Comment on attachment 411284 [details]
test

Testing

[Richard Townsend]

Comment on attachment 411284 [details]
test

Testing

[Richard Townsend]

Comment on attachment 411284 [details]
test

Testing

[Richard Townsend]

Comment on attachment 411284 [details]
test

Testing

[Richard Townsend]

Comment on attachment 411284 [details]
test

Testing

[Joey Arhar]

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

>>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:850
>>> +    //
>> 
>> 29
> 
> 29

29

>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:851
>> +    //
> 
> 30

30

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:852
> +

31

[Joey Arhar]

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:853
>      ASSERT(!m_contextLost);

32

[Joey Arhar]

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:853
>>      ASSERT(!m_contextLost);
> 
> 32

32

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:854
>      m_needsUpdate = true;

33

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:855
>      m_markedCanvasDirty = false;

34

[Joey Arhar]

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

>>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:853
>>>      ASSERT(!m_contextLost);
>> 
>> 32
> 
> 32

32

>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:854
>>      m_needsUpdate = true;
> 
> 33

33

>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:855
>>      m_markedCanvasDirty = false;
> 
> 34

34

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1349
>  

35

[Joey Arhar]

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1350
>  void WebGLRenderingContextBase::bindAttribLocation(WebGLProgram& program, GCGLuint index, const String& name)

36

[Joey Arhar]

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1351
>  {

37

[Joey Arhar]

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1352
> +    //

38

[Joey Arhar]

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1353
> +    //

39

[Joey Arhar]

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1353
>> +    //
> 
> 39

39

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1354
> +    // TESTING

40

[Joey Arhar]

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

>>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1353
>>> +    //
>> 
>> 39
> 
> 39

39

>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1354
>> +    // TESTING
> 
> 40

40

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1355
> +    //

41

[Joey Arhar]

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

>>>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1353
>>>> +    //
>>> 
>>> 39
>> 
>> 39
> 
> 39

39

>>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1354
>>> +    // TESTING
>> 
>> 40
> 
> 40

40

>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1355
>> +    //
> 
> 41

41

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1356
> +    //

42

[Joey Arhar]

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1357
> +

43

[Richard Townsend]

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

Testing

>>>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1354
>>>> +    // TESTING
>>> 
>>> 40
>> 
>> 40
> 
> 40

Testing

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4208
> +    //

Testing

[Richard Townsend]

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

TEsting

>> Source/WebCore/ChangeLog:17
>> +        (WebCore::WebGLRenderingContextBase::texSubImage2DBase):
> 
> 17

Testing

>>>>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1354
>>>>> +    // TESTING
>>>> 
>>>> 40
>>> 
>>> 40
>> 
>> 40
> 
> Testing

Testing

>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4208
>> +    //
> 
> Testing

Testing

[Joey Arhar]

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1358
>      if (isContextLostOrPending() || !validateWebGLProgramOrShader("bindAttribLocation", &program))

44

[Richard Townsend]

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

TEsting

>>> Source/WebCore/ChangeLog:17
>>> +        (WebCore::WebGLRenderingContextBase::texSubImage2DBase):
>> 
>> 17
> 
> Testing

Testing

>>>>>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1354
>>>>>> +    // TESTING
>>>>> 
>>>>> 40
>>>> 
>>>> 40
>>> 
>>> 40
>> 
>> Testing
> 
> Testing

Testing

>>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1355
>>> +    //
>> 
>> 41
> 
> 41

Testing

>>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4208
>>> +    //
>> 
>> Testing
> 
> Testing

Testing

[Richard Townsend]

Comment on attachment 411268 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411268&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1359
>          return;

Testing.

[Richard Townsend]

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:2558
> +    //

Testing

[Richard Townsend]

Comment on attachment 411268 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411268&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:853
>      ASSERT(!m_contextLost);

Test

[Richard Townsend]

Comment on attachment 411001 [details]
test patch 4

View in context: https://bugs.webkit.org/attachment.cgi?id=411001&action=review

> Source/WebCore/ChangeLog:18
> +        (WebCore::WebGLRenderingContextBase::texParameter):

Testing

[Richard Townsend]

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

Testing

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4209
> +

Testing

[Richard Townsend]

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

Testing.

>>>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1355
>>>> +    //
>>> 
>>> 41
>> 
>> 41
> 
> Testing

Testing.

[Richard Townsend]

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

>>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:855
>>>      m_markedCanvasDirty = false;
>> 
>> 34
> 
> 34

Testing

[Richard Townsend]

Comment on attachment 411268 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411268&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:849
> +    // TESTING

testing

>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:853
>>      ASSERT(!m_contextLost);
> 
> Test

c

[Richard Townsend]

Comment on attachment 411268 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411268&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:851
> +    //

Testing

[Richard Townsend]

Comment on attachment 411268 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411268&action=review

>>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:853
>>>      ASSERT(!m_contextLost);
>> 
>> Test
> 
> c

Testing

[Richard Townsend]

Comment on attachment 411014 [details]
test

Testing

[Richard Townsend]

Comment on attachment 411268 [details]
test

Testing

[Richard Townsend]

Comment on attachment 411284 [details]
test

Testing

[Richard Townsend]

Comment on attachment 409932 [details]
test patch

Testing

[Richard Townsend]

Comment on attachment 411014 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411014&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4207
> +    //

Testing

[Richard Townsend]

View in context: https://bugs.webkit.org/attachment.cgi?id=411014&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4207
> +    //

Testing

[Richard Townsend]

Comment on attachment 411268 [details]
test

Something

[Richard Townsend]

Comment on attachment 409934 [details]
test patch upload 3

Testing

[Richard Townsend]

Comment on attachment 409934 [details]
test patch upload 3

View in context: https://bugs.webkit.org/attachment.cgi?id=409934&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:852
> +

Testing

[Richard Townsend]

Comment on attachment 411268 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411268&action=review

Testing

> Source/WebCore/ChangeLog:16
> +        (WebCore::WebGLRenderingContextBase::readPixels):

Testing

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:2554
> +    //

Tetsting

[Richard Townsend]

Comment on attachment 411284 [details]
test

asdf

[Richard Townsend]

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:4207
> +    //

Testing

[Richard Townsend]

Comment on attachment 411284 [details]
test

asdfasdf

[Richard Townsend]

Comment on attachment 411284 [details]
test

Testing

[Richard Townsend]

Comment on attachment 409934 [details]
test patch upload 3

View in context: https://bugs.webkit.org/attachment.cgi?id=409934&action=review

Testing

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1356
> +    //

Testing

[Richard Townsend]

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1961
> +

Testing

[Richard Townsend]

Comment on attachment 409933 [details]
test patch upload 2

Testing

[Richard Townsend]

Comment on attachment 409933 [details]
test patch upload 2

Testing

[Richard Townsend]

Comment on attachment 411268 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411268&action=review

Test

> Source/WebCore/ChangeLog:21
>  

Test

[Richard Townsend]

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

>>>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:853
>>>>      ASSERT(!m_contextLost);
>>> 
>>> 32
>> 
>> 32
> 
> 32

Testing

[Richard Townsend]

Comment on attachment 409932 [details]
test patch

Testing

[Richard Townsend]

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

Testing

>> Source/WebCore/ChangeLog:16
>> +        (WebCore::WebGLRenderingContextBase::readPixels):
> 
> 16

Testing

[Richard Townsend]

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

Testing

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:5065
> +    //

Testing

[Richard Townsend]

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

>>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:851
>>> +    //
>> 
>> 30
> 
> 30

Testing

[Richard Townsend]

Comment on attachment 411277 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411277&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1356
> +    //

Testing

[Richard Townsend]

Comment on attachment 411121 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411121&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1960
> +    //

Testing

[Richard Townsend]

Comment on attachment 411014 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411014&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:850
> +    //

Testing

[Joey Arhar]

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

>> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1350
>>  void WebGLRenderingContextBase::bindAttribLocation(WebGLProgram& program, GCGLuint index, const String& name)
> 
> 36

36

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1359
>          return;

45

[Joey Arhar]

Comment on attachment 411284 [details]
test

View in context: https://bugs.webkit.org/attachment.cgi?id=411284&action=review

> Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:1360
>      if (!validateLocationLength("bindAttribLocation", name))

46

[Mason Freed]

Comment on attachment 409897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review

test

> Source/WebCore/ChangeLog:8
> +        No-op changes to have a place for code reviews.

testing 123

[Mason Freed]

Comment on attachment 409897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409897&action=review

test

>> Source/WebCore/ChangeLog:8
>> +        No-op changes to have a place for code reviews.
> 
> testing 123

testing 123

> Source/WebCore/ChangeLog:9
> +

testing again