Bug 217003 – Support OES_fbo_render_mipmap

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[James Darpinian]

Support OES_fbo_render_mipmap

[James Darpinian]

Created attachment 409761 [details]
Patch

[Kenneth Russell]

Comment on attachment 409761 [details]
Patch

Looks good to me. Have you verified locally that the extension test goes down the code path where the extension's enabled? r+

[Dean Jackson]

Comment on attachment 409761 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409761&action=review

> Source/WebCore/html/canvas/OESFBORenderMipmap.h:33
> +    WTF_MAKE_ISO_ALLOCATED(OESFBORenderMipmap);

Thanks for this. We missed that sub-classes need it in the patch where we added IsoHeap allocation to WebGLExtension and it ended up as the number 1 WebKit crash in iOS 14 :)

[James Darpinian]

Comment on attachment 409761 [details]
Patch

Yes, the extension works locally. Thanks!

[EWS]

Committed r267613: <https://trac.webkit.org/changeset/267613>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409761 [details].

[Radar WebKit Bug Importer]

<rdar://problem/69609581>

[Kenneth Russell]

(In reply to Dean Jackson from comment #3)
> Comment on attachment 409761 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=409761&action=review
> 
> > Source/WebCore/html/canvas/OESFBORenderMipmap.h:33
> > +    WTF_MAKE_ISO_ALLOCATED(OESFBORenderMipmap);
> 
> Thanks for this. We missed that sub-classes need it in the patch where we
> added IsoHeap allocation to WebGLExtension and it ended up as the number 1
> WebKit crash in iOS 14 :)

I think that was my patch from Bug 215599 - I'm sorry for breaking things!

[Alex Christensen]

http://trac.webkit.org/r267625

[Kenneth Russell]

*** Bug 141242 has been marked as a duplicate of this bug. ***