Bug 216990 - [LFC][IFC] Incorrect width value is set for partially collapsible trailing space
Summary: [LFC][IFC] Incorrect width value is set for partially collapsible trailing space
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-25 13:29 PDT by zalan
Modified: 2020-09-28 09:38 PDT (History)
5 users (show)

See Also:


Attachments
Patch (4.16 KB, patch)
2020-09-25 13:33 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (4.14 KB, patch)
2020-09-25 13:40 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2020-09-25 13:29:33 PDT
for letter-spacing
Comment 1 zalan 2020-09-25 13:33:16 PDT
Created attachment 409730 [details]
Patch
Comment 2 zalan 2020-09-25 13:40:32 PDT
Created attachment 409733 [details]
Patch
Comment 3 EWS 2020-09-25 14:47:19 PDT
Committed r267596: <https://trac.webkit.org/changeset/267596>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409733 [details].
Comment 4 Radar WebKit Bug Importer 2020-09-25 14:48:15 PDT
<rdar://problem/69595312>
Comment 5 Truitt Savell 2020-09-28 09:38:06 PDT
It looks like the new test fast/layoutformattingcontext/horizontal-sizing-with-trailing-letter-spacing.html

added in https://trac.webkit.org/changeset/267596/webkit'

is crashing on Mac Debug wk2

History: https://results.webkit.org/?suite=layout-tests&test=fast%2Flayoutformattingcontext%2Fhorizontal-sizing-with-trailing-letter-spacing.html

Application Specific Information:
CRASHING TEST: fast/layoutformattingcontext/horizontal-sizing-with-trailing-letter-spacing.html

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   com.apple.JavaScriptCore      	0x000000033db2fa9e WTFCrash + 14 (Assertions.cpp:295)
1   com.apple.WebCore             	0x000000031de425fb WTFCrashWithInfo(int, char const*, char const*, int) + 27
2   com.apple.WebCore             	0x00000003217aa39c WebCore::Layout::LayoutContext::verifyAndOutputMismatchingLayoutTree(WebCore::Layout::LayoutState const&, WebCore::RenderView const&) + 300
3   com.apple.WebCore             	0x0000000321b4c12f WebCore::FrameViewLayoutContext::layoutUsingFormattingContext() + 767 (FrameViewLayoutContext.cpp:87)
4   com.apple.WebCore             	0x0000000321b2d8dd WebCore::FrameViewLayoutContext::layout() + 2141 (FrameViewLayoutContext.cpp:234)