Bug 216980 - REGRESSION (r267516): `--use-gpu-process` no longer enables GPU process when running layout tests
Summary: REGRESSION (r267516): `--use-gpu-process` no longer enables GPU process when ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-25 10:31 PDT by Wenson Hsieh
Modified: 2020-09-25 12:04 PDT (History)
8 users (show)

See Also:


Attachments
Patch (2.37 KB, patch)
2020-09-25 10:37 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2020-09-25 10:31:00 PDT
SSIA
Comment 1 Wenson Hsieh 2020-09-25 10:37:58 PDT
Created attachment 409706 [details]
Patch
Comment 2 Tim Horton 2020-09-25 10:43:25 PDT
So glad these are strings
Comment 3 Tim Horton 2020-09-25 10:43:48 PDT
Maybe we should assert (just for the purposes of testrunner; we don't want to do something more drastic in production) that features exist when turning them on?
Comment 4 Wenson Hsieh 2020-09-25 10:49:48 PDT
(In reply to Tim Horton from comment #3)
> Maybe we should assert (just for the purposes of testrunner; we don't want
> to do something more drastic in production) that features exist when turning
> them on?

Sounds good — I’ll do this in a followup.
Comment 5 EWS 2020-09-25 12:03:30 PDT
Committed r267586: <https://trac.webkit.org/changeset/267586>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409706 [details].
Comment 6 Radar WebKit Bug Importer 2020-09-25 12:04:37 PDT
<rdar://problem/69585877>