Bug 216976 - [LFC][Out-of-flow] ASSERTION FAILED: !layoutBox.isOutOfFlowPositioned() in WebCore::Layout::FormattingContext::Geometry::computedHeightValue
Summary: [LFC][Out-of-flow] ASSERTION FAILED: !layoutBox.isOutOfFlowPositioned() in We...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-25 08:25 PDT by zalan
Modified: 2020-09-25 09:06 PDT (History)
5 users (show)

See Also:

Attachments
Patch (6.75 KB, patch)
2020-09-25 08:31 PDT, zalan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2020-09-25 08:25:59 PDT 
ssia
Comment 1 zalan 2020-09-25 08:31:31 PDT 
Created attachment 409697 [details]
Patch
Comment 2 Antti Koivisto 2020-09-25 08:33:05 PDT 
Comment on attachment 409697 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409697&action=review

> Source/WebCore/layout/FormattingContextGeometry.cpp:-1177
> -    // FIXME: Find out if min/max-height properties should also be taken into account here.

I guess we found out!
Comment 3 zalan 2020-09-25 08:39:51 PDT 
(In reply to Antti Koivisto from comment #2)
> Comment on attachment 409697 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=409697&action=review
> 
> > Source/WebCore/layout/FormattingContextGeometry.cpp:-1177
> > -    // FIXME: Find out if min/max-height properties should also be taken into account here.
> 
> I guess we found out!
Most certainly we did!
Comment 4 EWS 2020-09-25 09:05:48 PDT 
Committed r267572: <https://trac.webkit.org/changeset/267572>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409697 [details].
Comment 5 Radar WebKit Bug Importer 2020-09-25 09:06:18 PDT 
<rdar://problem/69574883>