Bug 216961 – REGRESSION (r267227): imported/w3c/web-platform-tests/xhr/event-timeout.any.html is a flaky failure

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Ryan Haddad]

imported/w3c/web-platform-tests/xhr/event-timeout.any.html is frequently failing on iOS simulator and macOS debug wk2 bots:

--- /Volumes/Data/slave/ios-simulator-13-release-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/xhr/event-timeout.any-expected.txt
+++ /Volumes/Data/slave/ios-simulator-13-release-tests-wk2/build/layout-test-results/imported/w3c/web-platform-tests/xhr/event-timeout.any-actual.txt
@@ -1,3 +1,3 @@
 
-PASS XMLHttpRequest: timeout event 
+FAIL XMLHttpRequest: timeout event assert_unreached: ontimeout not called. Reached unreachable code
 
https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fxhr%2Fevent-timeout.any.html

[Radar WebKit Bug Importer]

<rdar://problem/69548545>

[Diego Pino]

This test is also flaky in WPE and WebKitGTK ports.

https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fxhr%2Fevent-timeout.any.html&platform=GTK&platform=WPE

[youenn fablet]

Created attachment 416934 [details]
Patch

[EWS Watchlist]

This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess

[youenn fablet]

Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/27034

[Darin Adler]

Comment on attachment 416934 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416934&action=review

> LayoutTests/imported/w3c/web-platform-tests/xhr/event-timeout.any.js:17
> -  }, 10);
> +  }, 1000);

Will this be upstreamed?

[youenn fablet]

(In reply to Darin Adler from comment #6)
> Comment on attachment 416934 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=416934&action=review
> 
> > LayoutTests/imported/w3c/web-platform-tests/xhr/event-timeout.any.js:17
> > -  }, 10);
> > +  }, 1000);
> 
> Will this be upstreamed?

Yes, webkit-patch upload did it for me at https://github.com/web-platform-tests/wpt/pull/27034.
Now that it is r+ed, I will merge this WPT PR before landing this change.

[EWS]

Committed r271196: <https://trac.webkit.org/changeset/271196>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 416934 [details].