RESOLVED FIXED 216957
[LFC][IFC] Add helper functions to create LineBox::InlineBox objects for inline level boxes. 
https://bugs.webkit.org/show_bug.cgi?id=216957
Summary [LFC][IFC] Add helper functions to create LineBox::InlineBox objects for inli...
zalan
Reported 2020-09-24 20:55:30 PDT
and there's FIXME on the LineBox::InlineBox name
Attachments
Patch (10.13 KB, patch)
2020-09-24 21:02 PDT, zalan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2020-09-24 21:02:55 PDT
Created attachment 409653 [details] Patch
Simon Fraser (smfr)
Comment 2 2020-09-24 21:11:01 PDT
Comment on attachment 409653 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409653&action=review > Source/WebCore/layout/inlineformatting/InlineLineBox.cpp:37 > + , m_logicalRect({ }, logicalLeft, logicalSize.width(), logicalSize.height()) Argument order is confusing because FloatRect(float x, float y, float width, float height)
zalan
Comment 3 2020-09-24 21:49:09 PDT
(In reply to Simon Fraser (smfr) from comment #2) > Comment on attachment 409653 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=409653&action=review > > > Source/WebCore/layout/inlineformatting/InlineLineBox.cpp:37 > > + , m_logicalRect({ }, logicalLeft, logicalSize.width(), logicalSize.height()) > > Argument order is confusing because FloatRect(float x, float y, float > width, float height) Yeah, in layout I started using top, left, width, height. I might change it later.
EWS
Comment 4 2020-09-24 21:49:51 PDT
Committed r267557: <https://trac.webkit.org/changeset/267557> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409653 [details].
Radar WebKit Bug Importer
Comment 5 2020-09-24 21:50:17 PDT
<rdar://problem/69546533>
Note You need to log in before you can comment on or make changes to this bug.