Bug 216957 - [LFC][IFC] Add helper functions to create LineBox::InlineBox objects for inline level boxes.
Summary: [LFC][IFC] Add helper functions to create LineBox::InlineBox objects for inli...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-24 20:55 PDT by zalan
Modified: 2020-09-24 21:50 PDT (History)
4 users (show)

See Also:

Attachments
Patch (10.13 KB, patch)
2020-09-24 21:02 PDT, zalan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2020-09-24 20:55:30 PDT 
and there's FIXME on the LineBox::InlineBox name
Comment 1 zalan 2020-09-24 21:02:55 PDT 
Created attachment 409653 [details]
Patch
Comment 2 Simon Fraser (smfr) 2020-09-24 21:11:01 PDT 
Comment on attachment 409653 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409653&action=review

> Source/WebCore/layout/inlineformatting/InlineLineBox.cpp:37
> +    , m_logicalRect({ }, logicalLeft, logicalSize.width(), logicalSize.height())

Argument order is confusing because     FloatRect(float x, float y, float width, float height)
Comment 3 zalan 2020-09-24 21:49:09 PDT 
(In reply to Simon Fraser (smfr) from comment #2)
> Comment on attachment 409653 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=409653&action=review
> 
> > Source/WebCore/layout/inlineformatting/InlineLineBox.cpp:37
> > +    , m_logicalRect({ }, logicalLeft, logicalSize.width(), logicalSize.height())
> 
> Argument order is confusing because     FloatRect(float x, float y, float
> width, float height)
Yeah, in layout I started using top, left, width, height. I might change it later.
Comment 4 EWS 2020-09-24 21:49:51 PDT 
Committed r267557: <https://trac.webkit.org/changeset/267557>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409653 [details].
Comment 5 Radar WebKit Bug Importer 2020-09-24 21:50:17 PDT 
<rdar://problem/69546533>