WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
216939
Use more inline initialization and constexpr in WebAudio code
https://bugs.webkit.org/show_bug.cgi?id=216939
Summary
Use more inline initialization and constexpr in WebAudio code
Chris Dumez
Reported
2020-09-24 12:06:55 PDT
Use more inline initialization and constexpr in WebAudio code.
Attachments
Patch
(70.49 KB, patch)
2020-09-24 12:11 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Patch
(72.56 KB, patch)
2020-09-24 12:31 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2020-09-24 12:11:23 PDT
Created
attachment 409610
[details]
Patch
Darin Adler
Comment 2
2020-09-24 12:24:44 PDT
Comment on
attachment 409610
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=409610&action=review
> Source/WebCore/platform/audio/HRTFPanner.h:85 > + int m_azimuthIndex1 { UninitializedAzimuth };
Maybe these become optionals too?
> Source/WebCore/platform/audio/HRTFPanner.h:89 > + int m_azimuthIndex2 { UninitializedAzimuth };
Maybe these become optionals too?
Chris Dumez
Comment 3
2020-09-24 12:31:54 PDT
Created
attachment 409612
[details]
Patch
EWS
Comment 4
2020-09-24 13:10:11 PDT
Committed
r267544
: <
https://trac.webkit.org/changeset/267544
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 409612
[details]
.
Radar WebKit Bug Importer
Comment 5
2020-09-24 13:11:16 PDT
<
rdar://problem/69521117
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug