Bug 216927 - [GTK][WPE] Move proxy settings from WebKitContext to WebKitWebsiteDataManager
Summary: [GTK][WPE] Move proxy settings from WebKitContext to WebKitWebsiteDataManager
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks: 216041
  Show dependency treegraph
 
Reported: 2020-09-24 05:04 PDT by Carlos Garcia Campos
Modified: 2020-10-08 19:54 PDT (History)
6 users (show)

See Also:


Attachments
Patch (47.49 KB, patch)
2020-09-24 05:08 PDT, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2020-09-24 05:04:13 PDT
Make it per session instead of global to the network process.
Comment 1 Carlos Garcia Campos 2020-09-24 05:08:23 PDT
Created attachment 409561 [details]
Patch
Comment 2 EWS Watchlist 2020-09-24 05:08:56 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 EWS 2020-09-24 09:15:00 PDT
Committed r267534: <https://trac.webkit.org/changeset/267534>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409561 [details].
Comment 4 Adrian Perez 2020-09-24 11:40:16 PDT
Comment on attachment 409561 [details]
Patch

I know this has landed already, but I still want to explicitly
write r=me here (the changes look good), because we have the
agreement of having two reviewers agree on API changes 👍️