Bug 216909 - [Preferences] Start generating experimental feature preferences for legacy WebKit
Summary: [Preferences] Start generating experimental feature preferences for legacy We...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-23 18:01 PDT by Sam Weinig
Modified: 2020-09-25 10:16 PDT (History)
7 users (show)

See Also:

Attachments
Patch (191.61 KB, patch)
2020-09-23 18:15 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (189.59 KB, patch)
2020-09-23 19:02 PDT, Sam Weinig 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (190.06 KB, patch)
2020-09-23 19:27 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (190.21 KB, patch)
2020-09-23 19:54 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (185.16 KB, patch)
2020-09-24 07:04 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (185.29 KB, patch)
2020-09-24 07:30 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (185.70 KB, patch)
2020-09-24 08:00 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (185.81 KB, patch)
2020-09-24 08:26 PDT, Sam Weinig 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (185.90 KB, patch)
2020-09-24 10:14 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (172.85 KB, patch)
2020-09-24 15:31 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Show Obsolete (9) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2020-09-23 18:01:05 PDT 
[Preferences] Start generating experimental feature preferences for legacy WebKit
Comment 1 Sam Weinig 2020-09-23 18:15:16 PDT Comment hidden (obsolete)
Comment 2 Sam Weinig 2020-09-23 19:02:38 PDT Comment hidden (obsolete)
Comment 3 Sam Weinig 2020-09-23 19:27:28 PDT Comment hidden (obsolete)
Comment 4 Alex Christensen 2020-09-23 19:50:11 PDT 
Why do you think it's a good idea to do changes like this to WebKitLegacy, where we don't intend to do any big changes until we remove it?
Comment 5 Sam Weinig 2020-09-23 19:54:25 PDT Comment hidden (obsolete)
Comment 6 Sam Weinig 2020-09-23 19:56:50 PDT 
(In reply to Alex Christensen from comment #4)
> Why do you think it's a good idea to do changes like this to WebKitLegacy,
> where we don't intend to do any big changes until we remove it?

Because otherwise we will have to keep manually changing it in inconsistent and error prone ways every time features settings are added.
Comment 7 Sam Weinig 2020-09-24 07:04:56 PDT Comment hidden (obsolete)
Comment 8 Sam Weinig 2020-09-24 07:30:03 PDT Comment hidden (obsolete)
Comment 9 Sam Weinig 2020-09-24 08:00:13 PDT Comment hidden (obsolete)
Comment 10 Sam Weinig 2020-09-24 08:26:25 PDT Comment hidden (obsolete)
Comment 11 Sam Weinig 2020-09-24 10:14:44 PDT Comment hidden (obsolete)
Comment 12 Sam Weinig 2020-09-24 12:52:44 PDT Comment hidden (obsolete)
Comment 13 Sam Weinig 2020-09-24 15:10:27 PDT Comment hidden (obsolete)
Comment 14 Sam Weinig 2020-09-24 15:31:58 PDT 
Created attachment 409626 [details]
Patch
Comment 15 Sam Weinig 2020-09-24 17:24:14 PDT 
Now it is definitely ready for review.
Comment 16 Sam Weinig 2020-09-25 09:02:57 PDT 
Again, for reviewers, this is a stepping stone. Ultimate plan is to have these yaml files in WTF, and shared in someway between WebKitLegacy and WebKit2.
Comment 17 Chris Dumez 2020-09-25 09:09:15 PDT 
WebKitLegacy being deprecated and in maintenance mode, I am not convinced we want to expose experimental features there in general?
Comment 18 Sam Weinig 2020-09-25 09:50:04 PDT 
(In reply to Chris Dumez from comment #17)
> WebKitLegacy being deprecated and in maintenance mode, I am not convinced we
> want to expose experimental features there in general?

I am not sure what you are proposing here. Do you think it is better for everyone to just keep adding tons of additional WebPreferences code every time a new feature is added, because that is the status quo.
Comment 19 Sam Weinig 2020-09-25 10:04:11 PDT 
(In reply to Sam Weinig from comment #18)
> (In reply to Chris Dumez from comment #17)
> > WebKitLegacy being deprecated and in maintenance mode, I am not convinced we
> > want to expose experimental features there in general?
> 
> I am not sure what you are proposing here. Do you think it is better for
> everyone to just keep adding tons of additional WebPreferences code every
> time a new feature is added, because that is the status quo.

Chris has told me he is not opposed to landing this. So I am.
Comment 20 EWS 2020-09-25 10:04:51 PDT 
Committed r267575: <https://trac.webkit.org/changeset/267575>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409626 [details].
Comment 21 Radar WebKit Bug Importer 2020-09-25 10:05:22 PDT 
<rdar://problem/69578216>
Comment 22 Darin Adler 2020-09-25 10:16:18 PDT 
I agree that we don’t need to add API for turning features on and off to Legacy WebKit. On the other hand, for testing purposes, if the feature is going to work in Legacy WebKit, then we want it to be testable in Legacy WebKit.

Ideally we can separate the API from how we enable disable things for testing and avoid adding and removing API or even SPI as we develop new web technology features.

Turning features still under development on and off in a Safari Technology Preview or a similar context is a sort of in-between case that is also important. Separate Objective-C methods or properties for each feature don’t necessarily need to exist just because we want that system.