Bug 216903 - webkitpy: Make sw_vers the source of truth for the MacOS version
Summary: webkitpy: Make sw_vers the source of truth for the MacOS version
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-23 15:47 PDT by Jonathan Bedard
Modified: 2020-09-23 16:28 PDT (History)
5 users (show)

See Also:


Attachments
Patch (2.16 KB, patch)
2020-09-23 15:52 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2020-09-23 15:47:35 PDT
For compatibility reasons, platform.mac_ver() may return 10.16 instead of 11.0. In WebKit, we always want the actual macOS version, and should prefer the version as reported by sw_vers.
Comment 1 Radar WebKit Bug Importer 2020-09-23 15:47:49 PDT
<rdar://problem/69462735>
Comment 2 Jonathan Bedard 2020-09-23 15:52:08 PDT
Created attachment 409508 [details]
Patch
Comment 3 EWS 2020-09-23 16:28:55 PDT
Committed r267508: <https://trac.webkit.org/changeset/267508>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409508 [details].