RESOLVED FIXED 216881
[LFC][IFC] Precompute the collapsible trailing width for LineBreaker 
https://bugs.webkit.org/show_bug.cgi?id=216881
Summary [LFC][IFC] Precompute the collapsible trailing width for LineBreaker
zalan
Reported 2020-09-23 08:29:34 PDT
instead of looping through the candidate runs in LineBreaker.
Attachments
Patch (14.31 KB, patch)
2020-09-23 08:37 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (14.22 KB, patch)
2020-09-23 12:02 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2020-09-23 08:37:31 PDT
Created attachment 409477 [details] Patch
Antti Koivisto
Comment 2 2020-09-23 11:28:20 PDT
Comment on attachment 409477 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409477&action=review > Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp:240 > + if (isFullyCollapsible()) > + m_collapsibleTrailingWidth += logicalWidth; > + else { Can this early return avoiding the else branch?
zalan
Comment 3 2020-09-23 12:02:54 PDT
Created attachment 409493 [details] Patch
zalan
Comment 4 2020-09-23 12:03:40 PDT
(In reply to Antti Koivisto from comment #2) > Comment on attachment 409477 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=409477&action=review > > > Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp:240 > > + if (isFullyCollapsible()) > > + m_collapsibleTrailingWidth += logicalWidth; > > + else { > > Can this early return avoiding the else branch? absolutely!
EWS
Comment 5 2020-09-23 12:34:49 PDT
Committed r267494: <https://trac.webkit.org/changeset/267494> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409493 [details].
Radar WebKit Bug Importer
Comment 6 2020-09-23 12:35:19 PDT
<rdar://problem/69451507>
Note You need to log in before you can comment on or make changes to this bug.