Bug 216855 - Add CSSConditionRule and CSSGroupingRule
Summary: Add CSSConditionRule and CSSGroupingRule
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Darin Adler
URL:
Keywords: InRadar
: 200838 (view as bug list)
Depends on:
Blocks: 216940
  Show dependency tree / graph
 
Reported: 2020-09-22 15:52 PDT by Darin Adler
Modified: 2022-03-08 11:20 PST (History)
19 users (show)

See Also:

Attachments
Patch (88.74 KB, patch)
2020-09-22 17:03 PDT, Darin Adler 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (88.76 KB, patch)
2020-09-22 17:43 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (96.60 KB, patch)
2020-09-24 10:53 PDT, Darin Adler 		sam: review+
darin: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2020-09-22 15:52:58 PDT 
Add CSSConditionRule and CSSGroupingRule
Comment 1 Darin Adler 2020-09-22 17:03:51 PDT Comment hidden (obsolete)
Comment 2 Darin Adler 2020-09-22 17:43:56 PDT Comment hidden (obsolete)
Comment 3 Darin Adler 2020-09-24 10:53:13 PDT 
Created attachment 409597 [details]
Patch
Comment 4 Sam Weinig 2020-09-24 11:20:24 PDT 
Comment on attachment 409597 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409597&action=review

> Source/WebCore/css/CSSConditionRule.h:18
> + * This library is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU Library General Public
> + * License as published by the Free Software Foundation; either
> + * version 2 of the License, or (at your option) any later version.
> + *
> + * This library is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> + * Library General Public License for more details.
> + *
> + * You should have received a copy of the GNU Library General Public License
> + * along with this library; see the file COPYING.LIB.  If not, write to
> + * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
> + * Boston, MA 02110-1301, USA.
> + */

You seem to be using a very old lgpl license. Pretty sure we want new code to use the 2 clause BSD.
Comment 5 Darin Adler 2020-09-24 12:06:38 PDT 
Comment on attachment 409597 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409597&action=review

>> Source/WebCore/css/CSSConditionRule.h:18
>> + */
> 
> You seem to be using a very old lgpl license. Pretty sure we want new code to use the 2 clause BSD.

Oops, will fix that. Sorry, copied from the wrong header.
Comment 6 Darin Adler 2020-09-24 12:07:52 PDT 
Comment on attachment 409597 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409597&action=review

>>> Source/WebCore/css/CSSConditionRule.h:18
>>> + */
>> 
>> You seem to be using a very old lgpl license. Pretty sure we want new code to use the 2 clause BSD.
> 
> Oops, will fix that. Sorry, copied from the wrong header.

I think I used the correct one above in CSSConditionRule.cpp and that’s what I’ll use on all the new files.
Comment 7 Darin Adler 2020-09-24 15:42:11 PDT 
Tests passing, need review. I have fixed the licenses in my local copy.
Comment 8 Darin Adler 2020-09-25 10:19:55 PDT 
Committed r267576: <https://trac.webkit.org/changeset/267576>
Comment 9 Radar WebKit Bug Importer 2020-09-25 10:20:18 PDT 
<rdar://problem/69579125>
Comment 10 Joonghun Park 2021-09-24 10:25:03 PDT 
*** Bug 200838 has been marked as a duplicate of this bug. ***