RESOLVED FIXED 216831
Remove code behind ENABLE(MEDIA_SESSION), no ports enable it 
https://bugs.webkit.org/show_bug.cgi?id=216831
Summary Remove code behind ENABLE(MEDIA_SESSION), no ports enable it
Sam Weinig
Reported 2020-09-22 09:35:25 PDT
After talking with Eric Carlson, we think its time to remove all the code behind ENABLE(MEDIA_SESSION), no ports enable it and the spec has substantially changed since this was first implemented.
Attachments
Patch (279.10 KB, patch)
2020-09-22 18:29 PDT, Sam Weinig 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (285.06 KB, patch)
2020-09-22 19:28 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (286.19 KB, patch)
2020-09-23 04:37 PDT, Sam Weinig 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (286.69 KB, patch)
2020-09-23 04:56 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (286.95 KB, patch)
2020-09-30 08:33 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (287.44 KB, patch)
2020-09-30 09:03 PDT, Sam Weinig 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (287.44 KB, patch)
2020-09-30 09:11 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2020-09-22 18:29:49 PDT Comment hidden (obsolete)
Sam Weinig
Comment 2 2020-09-22 19:28:10 PDT Comment hidden (obsolete)
Sam Weinig
Comment 3 2020-09-23 04:37:20 PDT Comment hidden (obsolete)
Sam Weinig
Comment 4 2020-09-23 04:56:24 PDT Comment hidden (obsolete)
EWS
Comment 5 2020-09-23 10:46:46 PDT Comment hidden (obsolete)
Radar WebKit Bug Importer
Comment 6 2020-09-29 09:36:13 PDT
<rdar://problem/69750841>
Sam Weinig
Comment 7 2020-09-30 08:33:44 PDT Comment hidden (obsolete)
Sam Weinig
Comment 8 2020-09-30 09:03:39 PDT Comment hidden (obsolete)
Sam Weinig
Comment 9 2020-09-30 09:11:03 PDT
Created attachment 410129 [details] Patch
EWS
Comment 10 2020-09-30 10:11:01 PDT
Committed r267796: <https://trac.webkit.org/changeset/267796> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410129 [details].
Karl Rackler
Comment 11 2020-10-02 09:00:26 PDT
Reverted r267796 for reason: This change is breaking the build on internal debug bots. Committed r267883: <https://trac.webkit.org/changeset/267883>
Karl Rackler
Comment 12 2020-10-02 09:25:12 PDT
After reviewing with Tim and Sam relanding patch.
EWS
Comment 13 2020-10-02 09:39:51 PDT
Committed r267885: <https://trac.webkit.org/changeset/267885> All reviewed patches have been landed. Closing bug and clearing flags on attachment 410129 [details].
Note You need to log in before you can comment on or make changes to this bug.