Bug 216831 - Remove code behind ENABLE(MEDIA_SESSION), no ports enable it
Summary: Remove code behind ENABLE(MEDIA_SESSION), no ports enable it
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-22 09:35 PDT by Sam Weinig
Modified: 2020-10-19 12:59 PDT (History)
19 users (show)

See Also:


Attachments
Patch (279.10 KB, patch)
2020-09-22 18:29 PDT, Sam Weinig
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (285.06 KB, patch)
2020-09-22 19:28 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff
Patch (286.19 KB, patch)
2020-09-23 04:37 PDT, Sam Weinig
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (286.69 KB, patch)
2020-09-23 04:56 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff
Patch (286.95 KB, patch)
2020-09-30 08:33 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff
Patch (287.44 KB, patch)
2020-09-30 09:03 PDT, Sam Weinig
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (287.44 KB, patch)
2020-09-30 09:11 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2020-09-22 09:35:25 PDT
After talking with Eric Carlson, we think its time to remove all the code behind ENABLE(MEDIA_SESSION), no ports enable it and the spec has substantially changed since this was first implemented.
Comment 1 Sam Weinig 2020-09-22 18:29:49 PDT Comment hidden (obsolete)
Comment 2 Sam Weinig 2020-09-22 19:28:10 PDT Comment hidden (obsolete)
Comment 3 Sam Weinig 2020-09-23 04:37:20 PDT Comment hidden (obsolete)
Comment 4 Sam Weinig 2020-09-23 04:56:24 PDT Comment hidden (obsolete)
Comment 5 EWS 2020-09-23 10:46:46 PDT Comment hidden (obsolete)
Comment 6 Radar WebKit Bug Importer 2020-09-29 09:36:13 PDT
<rdar://problem/69750841>
Comment 7 Sam Weinig 2020-09-30 08:33:44 PDT Comment hidden (obsolete)
Comment 8 Sam Weinig 2020-09-30 09:03:39 PDT Comment hidden (obsolete)
Comment 9 Sam Weinig 2020-09-30 09:11:03 PDT
Created attachment 410129 [details]
Patch
Comment 10 EWS 2020-09-30 10:11:01 PDT
Committed r267796: <https://trac.webkit.org/changeset/267796>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410129 [details].
Comment 11 Karl Rackler 2020-10-02 09:00:26 PDT
Reverted r267796 for reason:

This change is breaking the build on internal debug bots.

Committed r267883: <https://trac.webkit.org/changeset/267883>
Comment 12 Karl Rackler 2020-10-02 09:25:12 PDT
After reviewing with Tim and Sam relanding patch.
Comment 13 EWS 2020-10-02 09:39:51 PDT
Committed r267885: <https://trac.webkit.org/changeset/267885>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410129 [details].