Bug 216826 – [iOS] In case of live media capture, activate capture icon

• Status: NEW
• Component: WebRTC

[youenn fablet]

[iOS] In case of live media capture, activate capture icon

[youenn fablet]

Created attachment 409890 [details]
WIP

[Eric Carlson]

Comment on attachment 409890 [details]
WIP

View in context: https://bugs.webkit.org/attachment.cgi?id=409890&action=review

> Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerDownloadTask.cpp:41
> +ServiceWorkerDownloadTask::ServiceWorkerDownloadTask(WebSWServerConnection& connection, WebCore::FetchIdentifier fetchIdentifier, ServiceWorkerIdentifier serviceWorkerIdentifier, ServiceWorkerRegistrationIdentifier serviceWorkerRegistrationIdentifier, PendingDownload& download, DownloadID downloadID, const WebCore::ResourceRequest& request, const WebCore::ResourceResponse& response)

Did you mean to include this file?

> Source/WebKit/NetworkProcess/ServiceWorker/ServiceWorkerDownloadTask.h:47
> +class ServiceWorkerDownloadTask : public CanMakeWeakPtr<ServiceWorkerDownloadTask> {

Ditto.

> Source/WebKit/UIProcess/Cocoa/WKMediaCaptureStatusBarManager.mm:188
> +    RELEASE_LOG_ERROR(WebRTC, "WKMediaCaptureStatusBarManagerSource/WebCore/PAL/pal/cf/SpringBoardServicesSoftLink.h  did invalidate status bar");

I don't think you meant to include the path in the logging output.

> Source/WebKit/WebProcess/GPU/media/AudioOutputProvider.cpp:34
> +void AudioOutputProvider::defaultAudioOutputDeviceChanged(Page& page)

Oops, you probably didn't mean to include this.

> Source/WebKit/WebProcess/GPU/media/AudioOutputProvider.h:32
> +class AudioOutputProvider : public WebCore::AudioOutputProvider {

Ditto.

[youenn fablet]

Created attachment 409907 [details]
WIP

[youenn fablet]

Created attachment 409986 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/69744048>

[youenn fablet]

Created attachment 409990 [details]
Patch

[youenn fablet]

Created attachment 409991 [details]
Patch