Bug 216825 - Correct instructions for building iOS in ReadMe
Summary: Correct instructions for building iOS in ReadMe
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-22 08:41 PDT by Jonathan Bedard
Modified: 2020-09-25 01:39 PDT (History)
5 users (show)

See Also:


Attachments
Patch (2.37 KB, patch)
2020-09-22 08:49 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2020-09-22 08:41:53 PDT
Chenfeng pointed out in https://bugs.webkit.org/show_bug.cgi?id=207043 that I forgot to update our top level ReadMe to agree with https://webkit.org/building-webkit/.
Comment 1 Radar WebKit Bug Importer 2020-09-22 08:44:18 PDT
<rdar://problem/69372654>
Comment 2 Jonathan Bedard 2020-09-22 08:49:43 PDT
Created attachment 409363 [details]
Patch
Comment 3 David Kilzer (:ddkilzer) 2020-09-22 09:39:54 PDT
Comment on attachment 409363 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409363&action=review

> ReadMe.md:99
> +where `platform` is `ios`, `tvos` or `watchos`.

Are we sure this is `tvos` and not `appletv`?  I've made that mistaken many times.  :)
Comment 4 Jonathan Bedard 2020-09-22 09:41:48 PDT
(In reply to David Kilzer (:ddkilzer) from comment #3)
> Comment on attachment 409363 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=409363&action=review
> 
> > ReadMe.md:99
> > +where `platform` is `ios`, `tvos` or `watchos`.
> 
> Are we sure this is `tvos` and not `appletv`?  I've made that mistaken many
> times.  :)

Yes, I made sure to check what our builders are passing: https://build.webkit.org/builders/Apple-tvOS-Simulator-13-Release-Build/builds/2605/steps/compile-webkit/logs/stdio
Comment 5 EWS 2020-09-22 09:45:53 PDT
Committed r267416: <https://trac.webkit.org/changeset/267416>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409363 [details].
Comment 6 Chenfeng Pan 2020-09-25 01:39:35 PDT
(In reply to Jonathan Bedard from comment #0)
> Chenfeng pointed out in https://bugs.webkit.org/show_bug.cgi?id=207043 that
> I forgot to update our top level ReadMe to agree with
> https://webkit.org/building-webkit/.

Sorry I just check my email today. And I find a shell command also needing to be updated.