Bug 216823 - REGRESSION(r267354): [Win] ImportError when starting wptserve
Summary: REGRESSION(r267354): [Win] ImportError when starting wptserve
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Windows 10
: P2 Normal
Assignee: Sam Sneddon [:gsnedders]
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-22 08:05 PDT by Sam Sneddon [:gsnedders]
Modified: 2020-09-22 09:54 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.80 KB, patch)
2020-09-22 08:34 PDT, Sam Sneddon [:gsnedders] 		no flags Details | Formatted Diff | Diff
Patch (1.85 KB, patch)
2020-09-22 09:08 PDT, Sam Sneddon [:gsnedders] 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Sneddon [:gsnedders] 2020-09-22 08:05:44 PDT 
see e.g., https://build.webkit.org/builders/WinCairo%2064-bit%20WKL%20Debug%20%28Tests%29/builds/3494/steps/layout-test/logs/stdio; reported by Stephan Szabo on Slack, caused by the `import resource` which is a Unix-only module in the Python stdlib.
Comment 1 Sam Sneddon [:gsnedders] 2020-09-22 08:34:46 PDT 
Created attachment 409361 [details]
Patch
Comment 2 EWS 2020-09-22 08:49:02 PDT 
/Volumes/Data/worker/Commit-Queue/build/LayoutTests/imported/w3c/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Comment 3 Sam Sneddon [:gsnedders] 2020-09-22 09:08:01 PDT 
Created attachment 409366 [details]
Patch
Comment 4 EWS 2020-09-22 09:08:24 PDT 
gsnedders@apple.com does not have committer permissions according to https://svn.webkit.org/repository/webkit/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

Rejecting attachment 409366 [details] from commit queue.
Comment 5 EWS 2020-09-22 09:53:36 PDT 
Committed r267417: <https://trac.webkit.org/changeset/267417>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409366 [details].
Comment 6 Radar WebKit Bug Importer 2020-09-22 09:54:20 PDT 
<rdar://problem/69376367>