Bug 216806 – Refactor build rules in Makefiles and Makefile.shared

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Keith Rollin]

Factor out the common aspects of the build rules in Makefile.shared and the various Makefiles. This allows us to more easily see what's different between the various build targets, and to apply uniform changes across all of the targets.

[Radar WebKit Bug Importer]

<rdar://problem/69332316>

[Keith Rollin]

Created attachment 409329 [details]
Patch

[Keith Rollin]

David, I really did a number on your set-sanitizer-configuration target. I think that what remains is equivalent to what you'd been doing, but I didn't understand all of what you'd implemented, so I'm not sure.

[David Kilzer (:ddkilzer)]

Comment on attachment 409329 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409329&action=review

r=me

> Source/Makefile:22
> +	@$(build_target_for_each_module)

This doesn't need to be @$(call build_target_for_each_module) as done in Makefile.shared?  Is that because we don't need to pass arguments?

> Makefile.shared:101
> +		[[ -t 1 ]] && COLOR_DIAGNOSTICS_ARG="COLOR_DIAGNOSTICS=YES"; \

I'm sorry, what does `[[ -t 1 ]]` do?!

> Makefile.shared:123
> +	@$(call set_webkit_configuration,--debug --force-optimization-level=O3)

This won't pass `--debug --force-optimization-level=O3` as a single string to the shell, will it?

[Keith Rollin]

(In reply to David Kilzer (:ddkilzer) from comment #4)
> Comment on attachment 409329 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=409329&action=review
> 
> r=me
> 
> > Source/Makefile:22
> > +	@$(build_target_for_each_module)
> 
> This doesn't need to be @$(call build_target_for_each_module) as done in
> Makefile.shared?  Is that because we don't need to pass arguments?

Correct.

> 
> > Makefile.shared:101
> > +		[[ -t 1 ]] && COLOR_DIAGNOSTICS_ARG="COLOR_DIAGNOSTICS=YES"; \
> 
> I'm sorry, what does `[[ -t 1 ]]` do?!

It checks to see if the specified file descriptor (in this case, stdout) is associated with a terminal.

> 
> > Makefile.shared:123
> > +	@$(call set_webkit_configuration,--debug --force-optimization-level=O3)
> 
> This won't pass `--debug --force-optimization-level=O3` as a single string
> to the shell, will it?

No. I checked for that. `Make` performs a simply text replacement and then processes the resulting string.

[EWS]

Committed r267424: <https://trac.webkit.org/changeset/267424>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409329 [details].

[Keith Rollin]

Committed r267441: <https://trac.webkit.org/changeset/267441>