Bug 216802 - Throw when AudioConnect::connect() is called for an output that has no channels
Summary: Throw when AudioConnect::connect() is called for an output that has no channels
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 212611
  Show dependency tree / graph
 
Reported: 2020-09-21 13:53 PDT by Chris Dumez
Modified: 2020-09-21 15:51 PDT (History)
8 users (show)

See Also:

Attachments
Patch (12.87 KB, patch)
2020-09-21 13:55 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-09-21 13:53:42 PDT 
Throw when AudioConnect::connect() is called for an output that has no channels, for consistency with Blink. The ScriptProcessorNode cannot have an output node that has zero channels.
Comment 1 Chris Dumez 2020-09-21 13:55:42 PDT 
Created attachment 409316 [details]
Patch
Comment 2 EWS 2020-09-21 15:50:53 PDT 
Committed r267376: <https://trac.webkit.org/changeset/267376>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409316 [details].
Comment 3 Radar WebKit Bug Importer 2020-09-21 15:51:17 PDT 
<rdar://problem/69332848>