Bug 216793 – [Contact Picker API] Introduce bindings for the Contact Picker API

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Aditya Keerthi]

Work towards implementing the Contact Picker API.

[Aditya Keerthi]

<rdar://problem/69317957>

[Aditya Keerthi]

Created attachment 409296 [details]
Patch

[Aditya Keerthi]

Created attachment 409298 [details]
Patch

[Aditya Keerthi]

Created attachment 409301 [details]
Patch

[Aditya Keerthi]

Created attachment 409328 [details]
Patch

[Aditya Keerthi]

Created attachment 409359 [details]
Patch

[Aditya Keerthi]

Created attachment 409364 [details]
Patch

[Aditya Keerthi]

Created attachment 409373 [details]
Attempt Windows fix

[Aditya Keerthi]

Created attachment 409391 [details]
Patch

[Aditya Keerthi]

Created attachment 409476 [details]
Patch

[Aditya Keerthi]

Created attachment 410369 [details]
Patch

[Wenson Hsieh]

Comment on attachment 410369 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410369&action=review

Looks good overall! I think we might need a clean build for Win EWS though.

> LayoutTests/contact-picker/contacts-interfaces.html:22
> +            shouldBeTrue("navigator.contacts.select(['name', 'email'], {multiple: true}) instanceof Promise");

I think it would be nice to test a few additional corner cases, like calling select with some strings that don’t map to enum values, or even non-strings, or an empty array, or passing in invalid ContactsSelectOptions.

[Aditya Keerthi]

(In reply to Wenson Hsieh from comment #12)
> Comment on attachment 410369 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=410369&action=review
> 
> Looks good overall! I think we might need a clean build for Win EWS though.

There's no longer a way to force clean builds (the "[clean-build]" functionality was removed). However, I did verify that a clean build passes on Win EWS – see the most recent obsoleted patch for proof.
 
> > LayoutTests/contact-picker/contacts-interfaces.html:22
> > +            shouldBeTrue("navigator.contacts.select(['name', 'email'], {multiple: true}) instanceof Promise");
> 
> I think it would be nice to test a few additional corner cases, like calling
> select with some strings that don’t map to enum values, or even non-strings,
> or an empty array, or passing in invalid ContactsSelectOptions.

I was planning on adding those tests along with the full implementation of ContactsManager.select() if that's alright?

[Wenson Hsieh]

Comment on attachment 410369 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410369&action=review

>>> LayoutTests/contact-picker/contacts-interfaces.html:22
>>> +            shouldBeTrue("navigator.contacts.select(['name', 'email'], {multiple: true}) instanceof Promise");
>> 
>> I think it would be nice to test a few additional corner cases, like calling select with some strings that don’t map to enum values, or even non-strings, or an empty array, or passing in invalid ContactsSelectOptions.
> 
> I was planning on adding those tests along with the full implementation of ContactsManager.select() if that's alright?

Sounds good.

[Aditya Keerthi]

Note: This will require a clean build on Windows bots once landed.

[EWS]

Committed r267988: <https://trac.webkit.org/changeset/267988>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 410369 [details].