Bug 216790 - AudioParam.exponentialRampToValueAtTime() does not properly deal with negative values
Summary: AudioParam.exponentialRampToValueAtTime() does not properly deal with negativ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://www.w3.org/TR/webaudio/#dom-a...
Keywords: InRadar
Depends on: 216788
Blocks: 212611
  Show dependency tree / graph
 
Reported: 2020-09-21 10:54 PDT by Chris Dumez
Modified: 2020-09-21 14:40 PDT (History)
6 users (show)

See Also:

Attachments
Patch (6.39 KB, patch)
2020-09-21 10:59 PDT, Chris Dumez 		eric.carlson: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-09-21 10:54:45 PDT 
AudioParam.exponentialRampToValueAtTime() does not properly deal with negative values.
The specification [1] says:
"If V0 and V1 have opposite signs or if V0 is zero, then v(t) = V0 for T0 <= t < T1."

Our implementation did not match the specification and would just special-case if either V0 or V1 was negative.

[1] https://www.w3.org/TR/webaudio/#dom-audioparam-exponentialramptovalueattime
Comment 1 Chris Dumez 2020-09-21 10:59:13 PDT 
Created attachment 409284 [details]
Patch
Comment 2 Chris Dumez 2020-09-21 14:17:52 PDT 
Committed r267367: <https://trac.webkit.org/changeset/267367>
Comment 3 Radar WebKit Bug Importer 2020-09-21 14:18:20 PDT 
<rdar://problem/69327008>