RESOLVED FIXED 216789
Functions should consistently enumerate length before name 
https://bugs.webkit.org/show_bug.cgi?id=216789
Summary Functions should consistently enumerate length before name
Keith Miller
Reported 2020-09-21 10:25:32 PDT
Functions should consistently enumerate length before name
Attachments
Patch (69.12 KB, patch)
2020-09-21 11:25 PDT, Keith Miller 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (69.13 KB, patch)
2020-09-21 11:57 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch for landing (69.16 KB, patch)
2020-09-21 13:06 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2020-09-21 11:25:26 PDT
Created attachment 409287 [details] Patch
Keith Miller
Comment 2 2020-09-21 11:57:22 PDT
Created attachment 409290 [details] Patch
Yusuke Suzuki
Comment 3 2020-09-21 12:56:28 PDT
Comment on attachment 409290 [details] Patch r=me
Mark Lam
Comment 4 2020-09-21 13:03:44 PDT
Comment on attachment 409290 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409290&action=review > Source/JavaScriptCore/runtime/InternalFunction.cpp:57 > + // The enumeration order is length then name so we have to make sure we add the properties in that order. /order is length then name so we/order must be length before name. So, we/
Keith Miller
Comment 5 2020-09-21 13:06:43 PDT
Comment on attachment 409290 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409290&action=review >> Source/JavaScriptCore/runtime/InternalFunction.cpp:57 >> + // The enumeration order is length then name so we have to make sure we add the properties in that order. > > /order is length then name so we/order must be length before name. So, we/ I changed it to "The enumeration order is length followed by name. So, we make sure to add the properties in that order."
Keith Miller
Comment 6 2020-09-21 13:06:55 PDT
Created attachment 409307 [details] Patch for landing
EWS
Comment 7 2020-09-21 13:41:12 PDT
Committed r267364: <https://trac.webkit.org/changeset/267364> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409307 [details].
Radar WebKit Bug Importer
Comment 8 2020-09-21 13:42:19 PDT
<rdar://problem/69324655>
Note You need to log in before you can comment on or make changes to this bug.