Bug 216780 - currentColor isn't recalculated when a text node doesn't exist
Summary: currentColor isn't recalculated when a text node doesn't exist
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: Safari 14
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL: https://jsfiddle.net/6tkyor3x/
Keywords: InRadar
: 216782 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-09-21 08:24 PDT by Cory LaViska
Modified: 2020-09-24 07:03 PDT (History)
13 users (show)

See Also:

Attachments
patch (6.10 KB, patch)
2020-09-24 03:38 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
patch (6.22 KB, patch)
2020-09-24 04:52 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
patch (6.22 KB, patch)
2020-09-24 04:54 PDT, Antti Koivisto 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cory LaViska 2020-09-21 08:24:00 PDT 
When an element doesn't contain a text node and currentColor is used for background-color, outline, and possibly other properties, the value isn't recalculated when the color changes.

This fiddle demonstrates the bug in a few lines of code. https://jsfiddle.net/6tkyor3x/
Comment 1 Cory LaViska 2020-09-21 08:24:42 PDT 
This affects Safari version 14.0 (15610.1.28.1.9, 15610).
Comment 2 Timothy Hatcher 2020-09-21 08:38:10 PDT 
*** Bug 216782 has been marked as a duplicate of this bug. ***
Comment 3 Radar WebKit Bug Importer 2020-09-21 12:45:31 PDT 
<rdar://problem/69320933>
Comment 4 Antti Koivisto 2020-09-24 02:25:26 PDT 
Style is computed correctly but we fail to repaint.
Comment 5 Antti Koivisto 2020-09-24 03:38:55 PDT 
Created attachment 409550 [details]
patch
Comment 6 Antti Koivisto 2020-09-24 04:52:13 PDT 
Created attachment 409556 [details]
patch
Comment 7 Antti Koivisto 2020-09-24 04:54:33 PDT 
Created attachment 409558 [details]
patch
Comment 8 EWS 2020-09-24 06:21:17 PDT 
Committed r267528: <https://trac.webkit.org/changeset/267528>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409558 [details].