Bug 216773 - [CMake] Use imported targets in find module for the ATK SPI2 bridge dependency
Summary: [CMake] Use imported targets in find module for the ATK SPI2 bridge dependency
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrian Perez
URL:
Keywords: InRadar
Depends on:
Blocks: 213990
  Show dependency tree / graph
 
Reported: 2020-09-21 04:27 PDT by Adrian Perez
Modified: 2020-09-23 14:31 PDT (History)
9 users (show)

See Also:

Attachments
Patch (7.48 KB, patch)
2020-09-21 05:52 PDT, Adrian Perez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Perez 2020-09-21 04:27:34 PDT 
On top of modernizing the find module, it should avoid the following warning:

-- Checking for module 'atk-bridge-2.0'
--   Found atk-bridge-2.0, version 2.34.2
CMake Warning (dev) at /usr/share/cmake-3.18/Modules/FindPackageHandleStandardArgs.cmake:273 (message):
  The package name passed to `find_package_handle_standard_args` (ATK_BRIDGE)
  does not match the name of the calling package (ATKBridge).  This can lead
  to problems in calling code that expects `find_package` result variables
  (e.g., `_FOUND`) to follow a certain pattern.
Call Stack (most recent call first):
  Source/cmake/FindATKBridge.cmake:47 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
  Source/cmake/WebKitFindPackage.cmake:104 (_find_package)
  Source/cmake/OptionsWPE.cmake:135 (find_package)
  Source/cmake/WebKitCommon.cmake:58 (include)
  CMakeLists.txt:173 (include)
This warning is for project developers.  Use -Wno-dev to suppress it.
Comment 1 Adrian Perez 2020-09-21 05:52:58 PDT 
Created attachment 409273 [details]
Patch
Comment 2 Adrian Perez 2020-09-21 23:50:11 PDT 
Thanks for the review, Don!
Comment 3 EWS 2020-09-21 23:52:20 PDT 
Committed r267399: <https://trac.webkit.org/changeset/267399>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409273 [details].
Comment 4 Radar WebKit Bug Importer 2020-09-21 23:53:18 PDT 
<rdar://problem/69353421>