Bug 216762 - toRTCIceProtocol should handle ssltcp candidates
Summary: toRTCIceProtocol should handle ssltcp candidates
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-21 00:12 PDT by youenn fablet
Modified: 2020-09-22 01:04 PDT (History)
11 users (show)

See Also:

Attachments
Patch (1.40 KB, patch)
2020-09-21 00:13 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (4.12 KB, patch)
2020-09-22 00:13 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (4.12 KB, patch)
2020-09-22 00:34 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2020-09-21 00:12:30 PDT 
ssltcp candidates are special unstandardised tcp candidates that are still generated
Comment 1 youenn fablet 2020-09-21 00:13:43 PDT 
Created attachment 409262 [details]
Patch
Comment 2 Darin Adler 2020-09-21 12:44:04 PDT 
Comment on attachment 409262 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409262&action=review

> Source/WebCore/ChangeLog:8
> +        Covered by loading hangout.google.com in Debug mode.

Seems like that’s not a great way to regression-test, though. Any thing else we can do?
Comment 3 youenn fablet 2020-09-21 13:19:58 PDT 
> > Source/WebCore/ChangeLog:8
> > +        Covered by loading hangout.google.com in Debug mode.
> 
> Seems like that’s not a great way to regression-test, though. Any thing else
> we can do?

We could use mock peer connection backends.
I'll do that.
Comment 4 youenn fablet 2020-09-22 00:13:12 PDT 
Created attachment 409351 [details]
Patch for landing
Comment 5 EWS 2020-09-22 00:33:12 PDT 
ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.
Comment 6 youenn fablet 2020-09-22 00:34:52 PDT 
Created attachment 409353 [details]
Patch for landing
Comment 7 EWS 2020-09-22 01:03:43 PDT 
Committed r267401: <https://trac.webkit.org/changeset/267401>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409353 [details].
Comment 8 Radar WebKit Bug Importer 2020-09-22 01:04:15 PDT 
<rdar://problem/69356002>