RESOLVED FIXED 216762
toRTCIceProtocol should handle ssltcp candidates 
https://bugs.webkit.org/show_bug.cgi?id=216762
Summary toRTCIceProtocol should handle ssltcp candidates
youenn fablet
Reported 2020-09-21 00:12:30 PDT
ssltcp candidates are special unstandardised tcp candidates that are still generated
Attachments
Patch (1.40 KB, patch)
2020-09-21 00:13 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.12 KB, patch)
2020-09-22 00:13 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.12 KB, patch)
2020-09-22 00:34 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2020-09-21 00:13:43 PDT
Created attachment 409262 [details] Patch
Darin Adler
Comment 2 2020-09-21 12:44:04 PDT
Comment on attachment 409262 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409262&action=review > Source/WebCore/ChangeLog:8 > + Covered by loading hangout.google.com in Debug mode. Seems like that’s not a great way to regression-test, though. Any thing else we can do?
youenn fablet
Comment 3 2020-09-21 13:19:58 PDT
> > Source/WebCore/ChangeLog:8 > > + Covered by loading hangout.google.com in Debug mode. > > Seems like that’s not a great way to regression-test, though. Any thing else > we can do? We could use mock peer connection backends. I'll do that.
youenn fablet
Comment 4 2020-09-22 00:13:12 PDT
Created attachment 409351 [details] Patch for landing
EWS
Comment 5 2020-09-22 00:33:12 PDT
ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.
youenn fablet
Comment 6 2020-09-22 00:34:52 PDT
Created attachment 409353 [details] Patch for landing
EWS
Comment 7 2020-09-22 01:03:43 PDT
Committed r267401: <https://trac.webkit.org/changeset/267401> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409353 [details].
Radar WebKit Bug Importer
Comment 8 2020-09-22 01:04:15 PDT
<rdar://problem/69356002>
Note You need to log in before you can comment on or make changes to this bug.