Bug 216757 - [LFC][BFC] Move hasClearance out of BoxGeometry
Summary: [LFC][BFC] Move hasClearance out of BoxGeometry
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-20 20:13 PDT by zalan
Modified: 2020-09-21 12:16 PDT (History)
6 users (show)

See Also:

Attachments
Patch (6.88 KB, patch)
2020-09-20 20:15 PDT, zalan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2020-09-20 20:13:04 PDT 
It belongs in BlockFormattingState
Comment 1 zalan 2020-09-20 20:15:59 PDT 
Created attachment 409255 [details]
Patch
Comment 2 Sam Weinig 2020-09-21 06:31:17 PDT 
Comment on attachment 409255 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409255&action=review

> Source/WebCore/ChangeLog:8
> +        Do not cache the hasClearance state in BoxGeometry.

Would be good to include the rationale for this change here.
Comment 3 EWS 2020-09-21 06:49:12 PDT 
Committed r267343: <https://trac.webkit.org/changeset/267343>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409255 [details].
Comment 4 Radar WebKit Bug Importer 2020-09-21 12:16:40 PDT 
<rdar://problem/69319234>