RESOLVED FIXED 216742
[LFC][IFC] InlineFormattingState should not store display lines and runs 
https://bugs.webkit.org/show_bug.cgi?id=216742
Summary [LFC][IFC] InlineFormattingState should not store display lines and runs
zalan
Reported 2020-09-19 20:45:31 PDT
FormattingStates should hold layout data only.
Attachments
Patch (56.33 KB, patch)
2020-09-19 20:55 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (56.38 KB, patch)
2020-09-19 21:06 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (55.74 KB, patch)
2020-09-20 06:41 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2020-09-19 20:55:10 PDT
Created attachment 409223 [details] Patch
zalan
Comment 2 2020-09-19 21:06:58 PDT
Created attachment 409224 [details] Patch
zalan
Comment 3 2020-09-20 06:41:00 PDT
Created attachment 409233 [details] Patch
Antti Koivisto
Comment 4 2020-09-20 06:47:02 PDT
Comment on attachment 409233 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409233&action=review > Source/WebCore/ChangeLog:15 > + In this patch, > + 1. Display related structures are completely moved out from Layout namespace > + - InlineFormattingContext does not generate display structures. > + - InlineFormattingState only stores layout data. > + - Layout tree verification works on layout geometry. > + - Layout structures do not embed Display types. > + 2. LayoutIntegration creates and maintains the required Display structures for painting and hittesting. > + 3. Display::Run does not use Layout types (InlineLayoutRect, InlineLayoutUnit). Nice!
EWS
Comment 5 2020-09-20 08:01:24 PDT
Committed r267325: <https://trac.webkit.org/changeset/267325> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409233 [details].
Radar WebKit Bug Importer
Comment 6 2020-09-21 12:00:38 PDT
<rdar://problem/69318285>
Note You need to log in before you can comment on or make changes to this bug.