Bug 216735 - AnalyserNode's getByteFrequencyData() / getFloatFrequencyData() should only do FFT analysis once per render quantum
Summary: AnalyserNode's getByteFrequencyData() / getFloatFrequencyData() should only d...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://www.w3.org/TR/webaudio/#dom-a...
Keywords: InRadar
Depends on:
Blocks: 212611 216736 216781
  Show dependency tree / graph
 
Reported: 2020-09-19 16:52 PDT by Chris Dumez
Modified: 2020-09-21 12:25 PDT (History)
10 users (show)

See Also:

Attachments
Patch (15.28 KB, patch)
2020-09-19 16:59 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-09-19 16:52:55 PDT 
AnalyserNode's getByteFrequencyData() / getFloatFrequencyData() should only do FFT analysis once per render quantum:
- https://www.w3.org/TR/webaudio/#dom-analysernode-getbytefrequencydata

"""
If another call to getByteFrequencyData() or getFloatFrequencyData() occurs within the same render quantum as a previous call, the current frequency data is not updated with the same data. Instead, the previously computed data is returned.
"""
Comment 1 Chris Dumez 2020-09-19 16:59:15 PDT 
Created attachment 409215 [details]
Patch
Comment 2 EWS 2020-09-21 11:56:29 PDT 
Committed r267349: <https://trac.webkit.org/changeset/267349>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409215 [details].
Comment 3 Radar WebKit Bug Importer 2020-09-21 12:25:52 PDT 
<rdar://problem/69319771>