Bug 216710 – Implementation for AXIsolatedObject::nextSibling and previousSibling.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Andres Gonzalez]

Implementation for AXIsolatedObject::nextSibling and previousSibling.

[Andres Gonzalez]

Created attachment 409161 [details]
Patch

[chris fleizach]

Comment on attachment 409161 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409161&action=review

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:347
> +    AXObjectCache* objectCache;

is this an improvement in style?

[Andres Gonzalez]

(In reply to chris fleizach from comment #2)
> Comment on attachment 409161 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=409161&action=review
> 
> > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:347
> > +    AXObjectCache* objectCache;
> 
> is this an improvement in style?

I guess not... First tried to have just one return statement, that I think was the style improvement, but then I added the check for the object cache which can be null and it is a bit cryptic now.

[Andres Gonzalez]

Created attachment 409166 [details]
Patch

[Andres Gonzalez]

(In reply to chris fleizach from comment #2)
> Comment on attachment 409161 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=409161&action=review
> 
> > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:347
> > +    AXObjectCache* objectCache;
> 
> is this an improvement in style?

I think it's better in latest revision. Thanks.

[EWS]

Committed r267320: <https://trac.webkit.org/changeset/267320>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409166 [details].

[Radar WebKit Bug Importer]

<rdar://problem/69317496>