Bug 216710 - Implementation for AXIsolatedObject::nextSibling and previousSibling.
Summary: Implementation for AXIsolatedObject::nextSibling and previousSibling.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andres Gonzalez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-18 12:03 PDT by Andres Gonzalez
Modified: 2020-09-21 11:48 PDT (History)
9 users (show)

See Also:

Attachments
Patch (7.25 KB, patch)
2020-09-18 12:29 PDT, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Patch (7.26 KB, patch)
2020-09-18 12:52 PDT, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Gonzalez 2020-09-18 12:03:40 PDT 
Implementation for AXIsolatedObject::nextSibling and previousSibling.
Comment 1 Andres Gonzalez 2020-09-18 12:29:27 PDT 
Created attachment 409161 [details]
Patch
Comment 2 chris fleizach 2020-09-18 12:32:05 PDT 
Comment on attachment 409161 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409161&action=review

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:347
> +    AXObjectCache* objectCache;

is this an improvement in style?
Comment 3 Andres Gonzalez 2020-09-18 12:43:09 PDT 
(In reply to chris fleizach from comment #2)
> Comment on attachment 409161 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=409161&action=review
> 
> > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:347
> > +    AXObjectCache* objectCache;
> 
> is this an improvement in style?

I guess not... First tried to have just one return statement, that I think was the style improvement, but then I added the check for the object cache which can be null and it is a bit cryptic now.
Comment 4 Andres Gonzalez 2020-09-18 12:52:14 PDT 
Created attachment 409166 [details]
Patch
Comment 5 Andres Gonzalez 2020-09-18 12:54:33 PDT 
(In reply to chris fleizach from comment #2)
> Comment on attachment 409161 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=409161&action=review
> 
> > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:347
> > +    AXObjectCache* objectCache;
> 
> is this an improvement in style?

I think it's better in latest revision. Thanks.
Comment 6 EWS 2020-09-19 11:52:40 PDT 
Committed r267320: <https://trac.webkit.org/changeset/267320>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409166 [details].
Comment 7 Radar WebKit Bug Importer 2020-09-21 11:48:54 PDT 
<rdar://problem/69317496>