Remove AnimationTimeline::animationsForElement() and the CSS Transitions and CSS Animations accessors on ElementAnimationRareData
Created attachment 409049 [details] Patch
Comment on attachment 409049 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=409049&action=review > Source/WebCore/animation/DocumentTimeline.cpp:338 > + if (auto* animations = renderer.element()->animations()) { Early return if renderer.element()->animations() is null? > Source/WebCore/animation/DocumentTimeline.cpp:360 > + if (auto* animations = renderer.element()->animations()) { Early return if renderer.element()->animations() is null? > Source/WebCore/animation/DocumentTimeline.cpp:379 > + if (auto* animations = renderer.element()->animations()) { Early return if renderer.element()->animations() is null? > Source/WebCore/animation/DocumentTimeline.cpp:401 > + if (auto* animations = renderer.element()->animations()) { Early return if element or renderer.element()->animations() are null?
(In reply to Simon Fraser (smfr) from comment #2) > Comment on attachment 409049 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=409049&action=review > > > Source/WebCore/animation/DocumentTimeline.cpp:338 > > + if (auto* animations = renderer.element()->animations()) { > > Early return if renderer.element()->animations() is null? > > > Source/WebCore/animation/DocumentTimeline.cpp:360 > > + if (auto* animations = renderer.element()->animations()) { > > Early return if renderer.element()->animations() is null? > > > Source/WebCore/animation/DocumentTimeline.cpp:379 > > + if (auto* animations = renderer.element()->animations()) { > > Early return if renderer.element()->animations() is null? > > > Source/WebCore/animation/DocumentTimeline.cpp:401 > > + if (auto* animations = renderer.element()->animations()) { > > Early return if element or renderer.element()->animations() are null? Yes, yes, yes and yes. Will fix in commit.
Created attachment 409054 [details] Patch for landing
Committed r267204: <https://trac.webkit.org/changeset/267204> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409054 [details].
<rdar://problem/69088172>