Bug 216654 - Remove AnimationTimeline::animationsForElement() and the CSS Transitions and CSS Animations accessors on ElementAnimationRareData
Summary: Remove AnimationTimeline::animationsForElement() and the CSS Transitions and ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-17 10:50 PDT by Antoine Quint
Modified: 2020-09-17 12:29 PDT (History)
9 users (show)

See Also:


Attachments
Patch (18.93 KB, patch)
2020-09-17 10:53 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff
Patch for landing (17.43 KB, patch)
2020-09-17 11:55 PDT, Antoine Quint
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2020-09-17 10:50:31 PDT
Remove AnimationTimeline::animationsForElement() and the CSS Transitions and CSS Animations accessors on ElementAnimationRareData
Comment 1 Antoine Quint 2020-09-17 10:53:34 PDT
Created attachment 409049 [details]
Patch
Comment 2 Simon Fraser (smfr) 2020-09-17 10:58:41 PDT
Comment on attachment 409049 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=409049&action=review

> Source/WebCore/animation/DocumentTimeline.cpp:338
> +    if (auto* animations = renderer.element()->animations()) {

Early return if renderer.element()->animations() is null?

> Source/WebCore/animation/DocumentTimeline.cpp:360
> +    if (auto* animations = renderer.element()->animations()) {

Early return if renderer.element()->animations() is null?

> Source/WebCore/animation/DocumentTimeline.cpp:379
> +    if (auto* animations = renderer.element()->animations()) {

Early return if renderer.element()->animations() is null?

> Source/WebCore/animation/DocumentTimeline.cpp:401
> +        if (auto* animations = renderer.element()->animations()) {

Early return if element or renderer.element()->animations() are null?
Comment 3 Antoine Quint 2020-09-17 11:12:00 PDT
(In reply to Simon Fraser (smfr) from comment #2)
> Comment on attachment 409049 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=409049&action=review
> 
> > Source/WebCore/animation/DocumentTimeline.cpp:338
> > +    if (auto* animations = renderer.element()->animations()) {
> 
> Early return if renderer.element()->animations() is null?
> 
> > Source/WebCore/animation/DocumentTimeline.cpp:360
> > +    if (auto* animations = renderer.element()->animations()) {
> 
> Early return if renderer.element()->animations() is null?
> 
> > Source/WebCore/animation/DocumentTimeline.cpp:379
> > +    if (auto* animations = renderer.element()->animations()) {
> 
> Early return if renderer.element()->animations() is null?
> 
> > Source/WebCore/animation/DocumentTimeline.cpp:401
> > +        if (auto* animations = renderer.element()->animations()) {
> 
> Early return if element or renderer.element()->animations() are null?

Yes, yes, yes and yes. Will fix in commit.
Comment 4 Antoine Quint 2020-09-17 11:55:28 PDT
Created attachment 409054 [details]
Patch for landing
Comment 5 EWS 2020-09-17 12:28:47 PDT
Committed r267204: <https://trac.webkit.org/changeset/267204>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409054 [details].
Comment 6 Radar WebKit Bug Importer 2020-09-17 12:29:16 PDT
<rdar://problem/69088172>