Bug 216651 - Rename ShouldAllowExternalSchemes to ShouldAllowExternalSchemesButNotAppLinks to clarify what this enum value is for.
Summary: Rename ShouldAllowExternalSchemes to ShouldAllowExternalSchemesButNotAppLinks...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: InRadar
Depends on:
Reported: 2020-09-17 09:50 PDT by Hoa Dinh
Modified: 2020-09-17 11:55 PDT (History)
8 users (show)

See Also:

Patch (11.99 KB, patch)
2020-09-17 10:10 PDT, Hoa Dinh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hoa Dinh 2020-09-17 09:50:40 PDT
During my investigation, it was hard to figure out what ShouldAllowExternalSchemes implied.
Renaming ShouldAllowExternalSchemes to ShouldAllowExternalSchemesButNotAppLinks should clarify what this enum value is for.
Comment 1 Hoa Dinh 2020-09-17 10:10:13 PDT
Created attachment 409048 [details]
Comment 2 EWS Watchlist 2020-09-17 10:10:50 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 EWS 2020-09-17 11:54:10 PDT
Committed r267203: <https://trac.webkit.org/changeset/267203>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409048 [details].
Comment 4 Radar WebKit Bug Importer 2020-09-17 11:55:22 PDT