RESOLVED FIXED 216651
Rename ShouldAllowExternalSchemes to ShouldAllowExternalSchemesButNotAppLinks to clarify what this enum value is for. 
https://bugs.webkit.org/show_bug.cgi?id=216651
Summary Rename ShouldAllowExternalSchemes to ShouldAllowExternalSchemesButNotAppLinks...
Hoa Dinh
Reported 2020-09-17 09:50:40 PDT
During my investigation, it was hard to figure out what ShouldAllowExternalSchemes implied. Renaming ShouldAllowExternalSchemes to ShouldAllowExternalSchemesButNotAppLinks should clarify what this enum value is for.
Attachments
Patch (11.99 KB, patch)
2020-09-17 10:10 PDT, Hoa Dinh 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Hoa Dinh
Comment 1 2020-09-17 10:10:13 PDT
Created attachment 409048 [details] Patch
EWS Watchlist
Comment 2 2020-09-17 10:10:50 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
EWS
Comment 3 2020-09-17 11:54:10 PDT
Committed r267203: <https://trac.webkit.org/changeset/267203> All reviewed patches have been landed. Closing bug and clearing flags on attachment 409048 [details].
Radar WebKit Bug Importer
Comment 4 2020-09-17 11:55:22 PDT
<rdar://problem/69085506>
Note You need to log in before you can comment on or make changes to this bug.