Bug 216622 - AudioBufferSourceNode.start() behavior is incorrect when offset is past the end of the buffer
Summary: AudioBufferSourceNode.start() behavior is incorrect when offset is past the e...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 212611
  Show dependency tree / graph
 
Reported: 2020-09-16 14:38 PDT by Chris Dumez
Modified: 2020-09-16 15:44 PDT (History)
10 users (show)

See Also:

Attachments
Patch (7.47 KB, patch)
2020-09-16 14:43 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-09-16 14:38:40 PDT 
AudioBufferSourceNode.start() behavior is incorrect when offset is past the end of the buffer. We are supposed to output silence. However, in order implementation, we were just resetting the offset to 0, playing the buffer from the beginning.
Comment 1 Chris Dumez 2020-09-16 14:43:21 PDT 
Created attachment 408957 [details]
Patch
Comment 2 Geoffrey Garen 2020-09-16 15:13:16 PDT 
Comment on attachment 408957 [details]
Patch

r=me
Comment 3 EWS 2020-09-16 15:43:19 PDT 
Committed r267169: <https://trac.webkit.org/changeset/267169>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 408957 [details].
Comment 4 Radar WebKit Bug Importer 2020-09-16 15:44:16 PDT 
<rdar://problem/69019737>