Bug 216590 - [WebIDL] Move navigator.cookieEnabled to its own interface mixin, matching the spec
Summary: [WebIDL] Move navigator.cookieEnabled to its own interface mixin, matching th...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-15 16:10 PDT by Sam Weinig
Modified: 2020-09-16 08:56 PDT (History)
10 users (show)

See Also:

Attachments
Patch (8.35 KB, patch)
2020-09-15 16:12 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2020-09-15 16:10:41 PDT 
[WebIDL] Move navigator.cookieEnabled to its own interface mixin, matching the spec
Comment 1 Sam Weinig 2020-09-15 16:12:30 PDT 
Created attachment 408878 [details]
Patch
Comment 2 youenn fablet 2020-09-16 00:02:43 PDT 
Comment on attachment 408878 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408878&action=review

> Source/WebCore/page/Navigator.idl:28
> +    // FIXME: Remove this. WebKit is the only engine that still has this.

we could create a bugzilla for it.

> Source/WebCore/page/Navigator.idl:36
> +Navigator includes NavigatorCookies;

Should probably be the first includes to keep lexical order.
Comment 3 Sam Weinig 2020-09-16 08:41:18 PDT 
(In reply to youenn fablet from comment #2)
> Comment on attachment 408878 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=408878&action=review
> 
> > Source/WebCore/page/Navigator.idl:28
> > +    // FIXME: Remove this. WebKit is the only engine that still has this.
> 
> we could create a bugzilla for it.
> 
> > Source/WebCore/page/Navigator.idl:36
> > +Navigator includes NavigatorCookies;
> 
> Should probably be the first includes to keep lexical order.

This was done to match the order in the spec.
Comment 4 EWS 2020-09-16 08:55:52 PDT 
Committed r267146: <https://trac.webkit.org/changeset/267146>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 408878 [details].
Comment 5 Radar WebKit Bug Importer 2020-09-16 08:56:18 PDT 
<rdar://problem/68991769>