RESOLVED FIXED 216590
[WebIDL] Move navigator.cookieEnabled to its own interface mixin, matching the spec 
https://bugs.webkit.org/show_bug.cgi?id=216590
Summary [WebIDL] Move navigator.cookieEnabled to its own interface mixin, matching th...
Sam Weinig
Reported 2020-09-15 16:10:41 PDT
[WebIDL] Move navigator.cookieEnabled to its own interface mixin, matching the spec
Attachments
Patch (8.35 KB, patch)
2020-09-15 16:12 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2020-09-15 16:12:30 PDT
Created attachment 408878 [details] Patch
youenn fablet
Comment 2 2020-09-16 00:02:43 PDT
Comment on attachment 408878 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=408878&action=review > Source/WebCore/page/Navigator.idl:28 > + // FIXME: Remove this. WebKit is the only engine that still has this. we could create a bugzilla for it. > Source/WebCore/page/Navigator.idl:36 > +Navigator includes NavigatorCookies; Should probably be the first includes to keep lexical order.
Sam Weinig
Comment 3 2020-09-16 08:41:18 PDT
(In reply to youenn fablet from comment #2) > Comment on attachment 408878 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=408878&action=review > > > Source/WebCore/page/Navigator.idl:28 > > + // FIXME: Remove this. WebKit is the only engine that still has this. > > we could create a bugzilla for it. > > > Source/WebCore/page/Navigator.idl:36 > > +Navigator includes NavigatorCookies; > > Should probably be the first includes to keep lexical order. This was done to match the order in the spec.
EWS
Comment 4 2020-09-16 08:55:52 PDT
Committed r267146: <https://trac.webkit.org/changeset/267146> All reviewed patches have been landed. Closing bug and clearing flags on attachment 408878 [details].
Radar WebKit Bug Importer
Comment 5 2020-09-16 08:56:18 PDT
<rdar://problem/68991769>
Note You need to log in before you can comment on or make changes to this bug.