Bug 216585 – Move TLS certificate bypass SPI from WebProcessPool to WebsiteDataStore

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Alex Christensen]

Move TLS certificate bypass SPI from WebProcessPool to WebsiteDataStore

[Alex Christensen]

Created attachment 408865 [details]
Patch

[Geoffrey Garen]

Comment on attachment 408865 [details]
Patch

r=me

[Alex Christensen]

Created attachment 408866 [details]
Patch

[EWS Watchlist]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Alex Christensen]

Created attachment 408867 [details]
Patch

[Alex Christensen]

Comment on attachment 408867 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408867&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:636
> +- (void)_allowTLSCertificate:(NSArray *)certificateChain forHost:(NSString *)host

I'm going to call this _allowCertificateChain:forHost: because a certificate is one element of the array.

[Alex Christensen]

Comment on attachment 408867 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408867&action=review

>> Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:636
>> +- (void)_allowTLSCertificate:(NSArray *)certificateChain forHost:(NSString *)host
> 
> I'm going to call this _allowCertificateChain:forHost: because a certificate is one element of the array.

_allowTLSCertificateChain

[Alex Christensen]

Created attachment 408880 [details]
Patch

[Carlos Garcia Campos]

Comment on attachment 408880 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408880&action=review

> Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp:1628
> -    context->priv->processPool->allowSpecificHTTPSCertificateForHost(webCertificateInfo.ptr(), String::fromUTF8(host));
> +    WebsiteDataStore::defaultDataStore()->allowSpecificHTTPSCertificateForHost(webCertificateInfo.ptr(), String::fromUTF8(host));

This should be:

auto& websiteDataStore = webkitWebsiteDataManagerGetDataStore(context->priv->websiteDataManager.get());
websiteDataStore.allowSpecificHTTPSCertificateForHost(webCertificateInfo.ptr(), String::fromUTF8(host));

The GLib API doesn't use the default data store.

[Alex Christensen]

Created attachment 408927 [details]
Patch

[EWS]

Committed r267155: <https://trac.webkit.org/changeset/267155>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 408927 [details].

[Radar WebKit Bug Importer]

<rdar://problem/69001622>