Bug 216583 - ScriptProcessorNode should throw when trying to change its channel count or channel count mode
Summary: ScriptProcessorNode should throw when trying to change its channel count or c...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on: 216579
Blocks: 212611 216584
  Show dependency treegraph
 
Reported: 2020-09-15 14:07 PDT by Chris Dumez
Modified: 2020-09-15 15:39 PDT (History)
6 users (show)

See Also:


Attachments
Patch (6.63 KB, patch)
2020-09-15 14:09 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-09-15 14:07:37 PDT
ScriptProcessorNode should throw when trying to change its channel count or channel count mode:
- https://www.w3.org/TR/webaudio/#audionode-channelcount-constraints
- https://www.w3.org/TR/webaudio/#audionode-channelcountmode-constraints
Comment 1 Chris Dumez 2020-09-15 14:09:16 PDT
Created attachment 408861 [details]
Patch
Comment 2 Geoffrey Garen 2020-09-15 15:36:38 PDT
Comment on attachment 408861 [details]
Patch

r=me
Comment 3 Chris Dumez 2020-09-15 15:38:02 PDT
Comment on attachment 408861 [details]
Patch

Clearing flags on attachment: 408861

Committed r267107: <https://trac.webkit.org/changeset/267107>
Comment 4 Chris Dumez 2020-09-15 15:38:04 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2020-09-15 15:39:17 PDT
<rdar://problem/68945910>