Bug 216574 - ANGLE EAGL EGL_ANGLE_iosurface_client_buffer implementation is incorrect for simulator
Summary: ANGLE EAGL EGL_ANGLE_iosurface_client_buffer implementation is incorrect for ...
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: ANGLE (show other bugs)
Version: WebKit Local Build
Hardware: iPhone / iPad iOS 13
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on: 215908
Blocks: webglangle
  Show dependency tree / graph
 
Reported: 2020-09-15 11:48 PDT by Kimmo Kinnunen
Modified: 2022-08-11 00:00 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2020-09-15 11:48:34 PDT 
ANGLE EAGL EGL_ANGLE_iosurface_client_buffer implementation is incorrect for simulator

- the buffer unpack state probably should be always set when calling glTexImage2D. Now it's only called if textureData != nullptr
- the unpack buffer should be set to nullptr
- the texture data base address should be obtained based on the plane of the texture 
https://developer.apple.com/documentation/iosurface/1419379-iosurfacegetbaseaddressofplane?language=objc
Comment 1 Kenneth Russell 2020-09-15 14:27:44 PDT 
Thanks for uncovering these issues Kimmo.

Do you plan to take this? I see I left a few TODOs in ANGLE's src/libANGLE/renderer/gl/eagl/IOSurfaceSurfaceEAGL.mm .
Comment 2 Radar WebKit Bug Importer 2020-09-22 12:00:28 PDT 
<rdar://problem/69384081>
Comment 3 Kimmo Kinnunen 2022-08-11 00:00:18 PDT 
EAGL is not supported anymore, closing