WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
216568
run-webkit-tests runs xcodebuild an unnecessary amount of times
https://bugs.webkit.org/show_bug.cgi?id=216568
Summary
run-webkit-tests runs xcodebuild an unnecessary amount of times
Tim Horton
Reported
2020-09-15 10:09:05 PDT
PlatformInfo tries to memoize calls to xcodebuild to determine SDKs and Xcode version, but there isn't a singleton PlatformInfo, so it doesn't work. Fixing this reduces the time to run a single test from ~7 seconds to ~3.
Attachments
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2020-09-22 10:10:18 PDT
<
rdar://problem/69377368
>
Kimmo Kinnunen
Comment 2
2022-06-30 04:05:11 PDT
https://github.com/WebKit/WebKit/pull/1941
Tim Horton
Comment 3
2022-06-30 10:44:47 PDT
kimmo++, thank you for fixing :)
EWS
Comment 4
2022-07-01 09:35:09 PDT
Committed
252047@main
(bac2308618bb): <
https://commits.webkit.org/252047@main
> Reviewed commits have been landed. Closing PR #1941 and removing active labels.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug