Bug 216560 - Clean up lazy frame loading
Summary: Clean up lazy frame loading
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Frames (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-15 09:26 PDT by Rob Buis
Modified: 2020-09-17 05:13 PDT (History)
2 users (show)

See Also:

Attachments
Patch (2.53 KB, patch)
2020-09-15 09:29 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (2.79 KB, patch)
2020-09-16 00:13 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (3.06 KB, patch)
2020-09-17 02:29 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2020-09-15 09:26:39 PDT 
Clean up lazy frame loading
Comment 1 Rob Buis 2020-09-15 09:29:25 PDT 
Created attachment 408825 [details]
Patch
Comment 2 Rob Buis 2020-09-16 00:13:10 PDT 
Created attachment 408900 [details]
Patch
Comment 3 youenn fablet 2020-09-17 01:14:52 PDT 
Comment on attachment 408900 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408900&action=review

> Source/WebKit/Shared/WebPreferences.yaml:2002
> +  humanReadableName: "Lazy Iframe Loading"

Should it be spelled IFrame?
Ditto above for LazyIFrameLoadingEnabled.
Comment 4 Rob Buis 2020-09-17 02:29:26 PDT 
Created attachment 409013 [details]
Patch
Comment 5 Rob Buis 2020-09-17 02:51:37 PDT 
Comment on attachment 408900 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408900&action=review

>> Source/WebKit/Shared/WebPreferences.yaml:2002
>> +  humanReadableName: "Lazy Iframe Loading"
> 
> Should it be spelled IFrame?
> Ditto above for LazyIFrameLoadingEnabled.

For the actual web preference I am copying ThirdPartyIframeRedirectBlockingEnabled. To avoid this naming problem I just lowercase to iframe now in the description, like ThirdPartyIframeRedirectBlockingEnabled does.
Comment 6 EWS 2020-09-17 05:12:23 PDT 
Committed r267187: <https://trac.webkit.org/changeset/267187>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409013 [details].
Comment 7 Radar WebKit Bug Importer 2020-09-17 05:13:16 PDT 
<rdar://problem/69061964>