Bug 216559 - Remove runtime setting for enabling/disabling the Cache API?
Summary: Remove runtime setting for enabling/disabling the Cache API?
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 216512
  Show dependency tree / graph
 
Reported: 2020-09-15 09:25 PDT by Sam Weinig
Modified: 2020-09-22 09:26 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2020-09-15 09:25:28 PDT 
Remove runtime setting for enabling/disabling the Cache API. It should always be enabled at this point.
Comment 1 Sam Weinig 2020-09-17 18:16:56 PDT 
Looking at the implementation, it looks like this feature was never implemented for WebKitLegacy and seems to be intertwined with the network disk cache in WebKit2.

Antti, Chris, can you remind me why the disk cache logic was put into WebKit2? Is it something we could bring into WebCore at some point and use for both WebKitLegacy and WebKit2?
Comment 2 Antti Koivisto 2020-09-18 09:02:32 PDT 
It was easier to make it WK2 only. It is not clear that risking breaking legacy clients by changing cache behavior is even desirable. The feature was introduced for WK2 clients with linked-on-or-after check.

We have plenty of other APIs that are not supported in WK1, right?
Comment 3 Sam Weinig 2020-09-18 09:07:07 PDT 
(In reply to Antti Koivisto from comment #2)
> It was easier to make it WK2 only. It is not clear that risking breaking
> legacy clients by changing cache behavior is even desirable. The feature was
> introduced for WK2 clients with linked-on-or-after check.
> 
> We have plenty of other APIs that are not supported in WK1, right?

I don't know. We certainly don't have it well documented what works in WebKit1 vs. WebKit2, which seems lie a pretty big potential footgun waiting to happen.
Comment 4 Radar WebKit Bug Importer 2020-09-22 09:26:15 PDT 
<rdar://problem/69374740>