Bug 216527 – preprocessor.pm: Use Cygwin::win_to_posix_path and Cygwin::posix_to_win_path instead of cygpath command

• Status: RESOLVED
• Resolution: FIXED
• Component: Bindings

[Fujii Hironori]

preprocessor.pm: Use Cygwin::win_to_posix_path and Cygwin::posix_to_win_path instead of cygpath command

[Fujii Hironori]

Created attachment 408794 [details]
Patch

[Stephan Szabo]

Comment on attachment 408794 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408794&action=review

> Source/WebCore/bindings/scripts/preprocessor.pm:73
> +        if ($preprocessorAndFlags[0] =~ "cl.exe") {

It seems strange to me to assume that only a cl.exe invocation would be in a windows path. Or that you didn't (for example) have a non-cygwin windows build of clang that might need a windows path to the filename even if the perl being run is cygwin perl.

[Fujii Hironori]

Comment on attachment 408794 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408794&action=review

>> Source/WebCore/bindings/scripts/preprocessor.pm:73
>> +        if ($preprocessorAndFlags[0] =~ "cl.exe") {
> 
> It seems strange to me to assume that only a cl.exe invocation would be in a windows path. Or that you didn't (for example) have a non-cygwin windows build of clang that might need a windows path to the filename even if the perl being run is cygwin perl.

Yup, this code can support only cl.exe and clang-cl.exe for Windows path, others (gcc and g++) for Cygwin path.

[Fujii Hironori]

Comment on attachment 408794 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408794&action=review

> Source/WebCore/bindings/scripts/preprocessor.pm:74
> +            $preprocessorAndFlags[0] = Cygwin::win_to_posix_path($preprocessorAndFlags[0]);

Theoretically, I should always do this part "$preprocessorAndFlags[0] = Cygwin::win_to_posix_path($preprocessorAndFlags[0]);" for Cygwin perl even for cl.exe. Will fix.

[Fujii Hironori]

Created attachment 408857 [details]
Patch

[Fujii Hironori]

Comment on attachment 408857 [details]
Patch

Clearing flags on attachment: 408857

Committed r267101: <https://trac.webkit.org/changeset/267101>

[Fujii Hironori]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/68942823>