Bug 216525 - [Apple Win] Migrate the first part of SimpleFontData{CG}Win.cpp to FontCoreText.cpp
Summary: [Apple Win] Migrate the first part of SimpleFontData{CG}Win.cpp to FontCoreTe...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks: 216353
  Show dependency tree / graph
 
Reported: 2020-09-14 21:17 PDT by Myles C. Maxfield
Modified: 2020-09-15 16:35 PDT (History)
3 users (show)

See Also:

Attachments
WIP (8.29 KB, patch)
2020-09-14 21:17 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (12.18 KB, patch)
2020-09-14 21:34 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (12.97 KB, patch)
2020-09-15 14:19 PDT, Myles C. Maxfield 		dino: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2020-09-14 21:17:21 PDT 
This is the next step of migrating the Apple Win port off CGFont and on to CTFont.
Comment 1 Myles C. Maxfield 2020-09-14 21:17:47 PDT 
Created attachment 408787 [details]
WIP
Comment 2 Myles C. Maxfield 2020-09-14 21:34:33 PDT 
Created attachment 408788 [details]
Patch
Comment 3 Myles C. Maxfield 2020-09-15 14:19:14 PDT 
Created attachment 408863 [details]
Patch
Comment 4 Dean Jackson 2020-09-15 16:29:46 PDT 
Comment on attachment 408863 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408863&action=review

> Source/WebCore/platform/graphics/win/SimpleFontDataCairoWin.cpp:111
> +    // is *not* fixed pitch. Unbelievable but true.

Add "!"
Comment 5 Myles C. Maxfield 2020-09-15 16:34:56 PDT 
Committed r267112: <https://trac.webkit.org/changeset/267112>
Comment 6 Radar WebKit Bug Importer 2020-09-15 16:35:17 PDT 
<rdar://problem/68949143>