Bug 216502 - [LFC][FFC] Block box flex items establish block formatting contexts
Summary: [LFC][FFC] Block box flex items establish block formatting contexts
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-14 16:34 PDT by zalan
Modified: 2020-09-14 17:41 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.47 KB, patch)
2020-09-14 16:40 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (5.47 KB, patch)
2020-09-14 17:01 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2020-09-14 16:34:31 PDT
1. A block box that establishes an independent formatting context establishes a new block formatting context for its contents.
2. The display value of a flex item is blockified: if the specified display of an in-flow child of an element generating a flex container is an inline-level value, it computes to its block-level equivalent.
Comment 1 zalan 2020-09-14 16:40:51 PDT
Created attachment 408760 [details]
Patch
Comment 2 Simon Fraser (smfr) 2020-09-14 16:47:05 PDT
Comment on attachment 408760 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408760&action=review

> Source/WebCore/layout/layouttree/LayoutBox.h:108
>      bool isBlockLevelBox() const;
> +    bool isBlockBox() const;

I think a comment is justified to explain the different between BlockLevelBox and BlockBox
Comment 3 zalan 2020-09-14 16:51:56 PDT
(In reply to Simon Fraser (smfr) from comment #2)
> Comment on attachment 408760 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=408760&action=review
> 
> > Source/WebCore/layout/layouttree/LayoutBox.h:108
> >      bool isBlockLevelBox() const;
> > +    bool isBlockBox() const;
> 
> I think a comment is justified to explain the different between
> BlockLevelBox and BlockBox
I can copy&paste them from the .cpp (these are all spec terms btw).
Comment 4 zalan 2020-09-14 17:01:34 PDT
Created attachment 408763 [details]
Patch
Comment 5 EWS 2020-09-14 17:40:23 PDT
Committed r267059: <https://trac.webkit.org/changeset/267059>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 408763 [details].
Comment 6 Radar WebKit Bug Importer 2020-09-14 17:41:16 PDT
<rdar://problem/68889640>