Bug 216502 – [LFC][FFC] Block box flex items establish block formatting contexts

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[zalan]

1. A block box that establishes an independent formatting context establishes a new block formatting context for its contents.
2. The display value of a flex item is blockified: if the specified display of an in-flow child of an element generating a flex container is an inline-level value, it computes to its block-level equivalent.

[zalan]

Created attachment 408760 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 408760 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408760&action=review

> Source/WebCore/layout/layouttree/LayoutBox.h:108
>      bool isBlockLevelBox() const;
> +    bool isBlockBox() const;

I think a comment is justified to explain the different between BlockLevelBox and BlockBox

[zalan]

(In reply to Simon Fraser (smfr) from comment #2)
> Comment on attachment 408760 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=408760&action=review
> 
> > Source/WebCore/layout/layouttree/LayoutBox.h:108
> >      bool isBlockLevelBox() const;
> > +    bool isBlockBox() const;
> 
> I think a comment is justified to explain the different between
> BlockLevelBox and BlockBox
I can copy&paste them from the .cpp (these are all spec terms btw).

[zalan]

Created attachment 408763 [details]
Patch

[EWS]

Committed r267059: <https://trac.webkit.org/changeset/267059>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 408763 [details].

[Radar WebKit Bug Importer]

<rdar://problem/68889640>