Bug 216496 - [webkitcorepy] AutoInstaller should work with HomeBrew Python
Summary: [webkitcorepy] AutoInstaller should work with HomeBrew Python
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-14 14:33 PDT by Jonathan Bedard
Modified: 2020-09-14 16:05 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.22 KB, patch)
2020-09-14 14:42 PDT, Jonathan Bedard 		beidson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2020-09-14 14:33:14 PDT 
The AutoInstaller doesn't work with HomeBrew Python at the moment. I'm pretty sure that the AutoInstaller is broken inside some virtualenvs for the same reason.
Comment 1 Jonathan Bedard 2020-09-14 14:36:42 PDT 
<rdar://problem/68864294>
Comment 2 Jonathan Bedard 2020-09-14 14:42:30 PDT 
Created attachment 408747 [details]
Patch
Comment 3 Jonathan Bedard 2020-09-14 14:58:24 PDT 
HomeBrew sets a default install prefix which ends up conflicting with --home. We just need to override it when calling setup.py.
Comment 4 Brady Eidson 2020-09-14 15:02:26 PDT 
Comment on attachment 408747 [details]
Patch

(Rubberstamp, but... sure!)
Comment 5 Jonathan Bedard 2020-09-14 16:05:13 PDT 
Committed r267056: <https://trac.webkit.org/changeset/267056>