Bug 216486 – Web Inspector: REGRESSION(r266885): dyld: Symbol not found: __ZN9Inspector17BackendDispatcher12sendResponseElON3WTF6RefPtrINS1_8JSONImpl6ObjectENS1_13DumbPtrTraitsIS4_EEEEb

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

```
dyld: Symbol not found: __ZN9Inspector17BackendDispatcher12sendResponseElON3WTF6RefPtrINS1_8JSONImpl6ObjectENS1_13DumbPtrTraitsIS4_EEEEb
  Referenced from: /System/Library/PrivateFrameworks/WebInspector.framework/Versions/A/WebInspector
  Expected in: ~/dev/WebKit/WebKitBuild/Debug/JavaScriptCore.framework/Versions/A/JavaScriptCore
 in /System/Library/PrivateFrameworks/WebInspector.framework/Versions/A/WebInspector
```

[Devin Rousso]

Created attachment 408729 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 408729 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408729&action=review

rs=me

> Source/JavaScriptCore/inspector/InspectorBackendDispatcher.cpp:201
> +    sendResponse(requestId, result.releaseNonNull(), false);

Should it send the `bool` passed into this function, even though it is "unused"?

[Devin Rousso]

Comment on attachment 408729 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408729&action=review

>> Source/JavaScriptCore/inspector/InspectorBackendDispatcher.cpp:201
>> +    sendResponse(requestId, result.releaseNonNull(), false);
> 
> Should it send the `bool` passed into this function, even though it is "unused"?

IIRC this `bool` only exists to differentiate this `sendResponse` from the `sendResponse` in <https://trac.webkit.org/browser/trunk/Source/JavaScriptCore/inspector/cocoa/DeprecatedInspectorValues.cpp#L195>.

This also matches the behavior before r266885.

[EWS]

Committed r267028: <https://trac.webkit.org/changeset/267028>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 408729 [details].

[Radar WebKit Bug Importer]

<rdar://problem/68871288>

[Marcos Caceres]

This seems to have regressed again... 

STR:
 1. build-webkit --debug
 2. run-safari --debug 

Expected: Safari to start up

Actual:
```
Starting SafariForWebKitDevelopment with DYLD_FRAMEWORK_PATH set to point to built WebKit in /Users/mcaceres/dev/WebKit/WebKitBuild/Debug.
dyld: Symbol not found: __ZN9Inspector17BackendDispatcher12sendResponseElON3WTF6RefPtrINS1_8JSONImpl6ObjectENS1_13DumbPtrTraitsIS4_EEEEb
  Referenced from: /System/Library/PrivateFrameworks/WebInspector.framework/Versions/A/WebInspector
  Expected in: /Users/mcaceres/dev/WebKit/WebKitBuild/Debug/JavaScriptCore.framework/Versions/A/JavaScriptCore
 in /System/Library/PrivateFrameworks/WebInspector.framework/Versions/A/WebInspector
```

[Blaze Burg]

Marcos, this is fallout from JavaScriptCore breaking ABI compatibility. For this to not be hit will require the changes in WebInspector.framework to be in your system library. This won't happen until you update Safari. The fix for this should be in Safari 14.1 beta, which is available via here: https://developer.apple.com/safari/download/

[Marcos Caceres]

Thanks, BJ. Appreciate the update! I'll give the beta a go.

[Blaze Burg]

*** Bug 221528 has been marked as a duplicate of this bug. ***