Bug 216485 - Remove bogus asserts in FTLLower that assume programs are compiled with sensible speculations
Summary: Remove bogus asserts in FTLLower that assume programs are compiled with sensi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-14 11:25 PDT by Saam Barati
Modified: 2020-09-14 13:06 PDT (History)
15 users (show)

See Also:

Attachments
patch (4.75 KB, patch)
2020-09-14 11:45 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2020-09-14 11:25:19 PDT 
...
Comment 1 Saam Barati 2020-09-14 11:40:03 PDT 
<rdar://problem/68562804>
Comment 2 Saam Barati 2020-09-14 11:45:27 PDT 
Created attachment 408731 [details]
patch
Comment 3 Keith Miller 2020-09-14 11:52:11 PDT 
Comment on attachment 408731 [details]
patch

r=me. I'm a little sad that this may mean we are allowing a "new" OSR exit loop but I guess we should solve that with a fuzzing flag to try to detect it.
Comment 4 Saam Barati 2020-09-14 12:51:55 PDT 
(In reply to Keith Miller from comment #3)
> Comment on attachment 408731 [details]
> patch
> 
> r=me. I'm a little sad that this may mean we are allowing a "new" OSR exit
> loop but I guess we should solve that with a fuzzing flag to try to detect
> it.

I agree about your fuzzier idea, but nothing about this patch has to do with OSR exit loops. Nothing here proves we would or wouldn’t have a loop
Comment 5 EWS 2020-09-14 13:06:28 PDT 
Committed r267032: <https://trac.webkit.org/changeset/267032>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 408731 [details].