Bug 216473 – Move Media in GPU Process flag from internal to experimental

• Status: REOPENED
• Component: Media

[youenn fablet]

Move Media in GPU Process flag from internal to experimental

[youenn fablet]

Created attachment 408687 [details]
Patch

[youenn fablet]

Created attachment 408697 [details]
Patch

[youenn fablet]

ping review

[Jonathan Bedard]

(In reply to youenn fablet from comment #3)
> ping review

I don't think I'm the right reviewer for this.

[Peng Liu]

Comment on attachment 408697 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408697&action=review

> Tools/WebKitTestRunner/TestController.cpp:840
> +    // All experimental features except:

Do we need to move this code section down? After the loop?

[youenn fablet]

Comment on attachment 408697 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408697&action=review

>> Tools/WebKitTestRunner/TestController.cpp:840
>> +    // All experimental features except:
> 
> Do we need to move this code section down? After the loop?

No, we want to have options set inside the tests to override the default values.
In the future, we could update the WebPrefereneces.yank script to add an option to opt out some of the experimental features.

[Radar WebKit Bug Importer]

<rdar://problem/69318786>

[youenn fablet]

Created attachment 409352 [details]
Patch for landing

[youenn fablet]

Created attachment 409354 [details]
Patch for landing

[EWS]

Committed r267403: <https://trac.webkit.org/changeset/267403>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 409354 [details].

[Truitt Savell]

Reverted r267403 for reason:

Caused 50+ Crashes on iOS Debug

Committed r267479: <https://trac.webkit.org/changeset/267479>