Bug 216466 - [LFC Display] First steps towards LFC painting in WebKit2
Summary: [LFC Display] First steps towards LFC painting in WebKit2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on: 216482
Blocks:
  Show dependency tree / graph
 
Reported: 2020-09-13 16:10 PDT by Simon Fraser (smfr)
Modified: 2020-09-14 11:40 PDT (History)
11 users (show)

See Also:

Attachments
Patch (30.54 KB, patch)
2020-09-13 16:17 PDT, Simon Fraser (smfr) 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (30.56 KB, patch)
2020-09-13 16:23 PDT, Simon Fraser (smfr) 		zalan: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (35.81 KB, patch)
2020-09-13 21:00 PDT, Simon Fraser (smfr) 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (39.01 KB, patch)
2020-09-14 10:08 PDT, Simon Fraser (smfr) 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (40.90 KB, patch)
2020-09-14 10:26 PDT, Simon Fraser (smfr) 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (44.24 KB, patch)
2020-09-14 10:42 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2020-09-13 16:10:29 PDT 
First steps towards LFC painting in WebKit2
Comment 1 Simon Fraser (smfr) 2020-09-13 16:17:14 PDT 
Created attachment 408665 [details]
Patch
Comment 2 Simon Fraser (smfr) 2020-09-13 16:23:36 PDT 
Created attachment 408666 [details]
Patch
Comment 3 zalan 2020-09-13 18:57:25 PDT 
Comment on attachment 408666 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408666&action=review

> Source/WebCore/layout/display/DisplayLayerController.cpp:83
> +    if (!layoutState.hasDisplayBox(rootLayoutBox))
> +        return;

Shouldn't this be an ASSERT instead? We should never try to paint unless we have computed geometry (completed a layout).

> Source/WebCore/layout/display/DisplayView.cpp:89
> +

extra line

> Source/WebCore/layout/display/DisplayView.h:65
> +    // FIXME: Do we need to use LayoutTreeContent?

I really hope not.
I think we should figure out a way to have no dependency on LayoutState either. Display::Boxes are part of the state as they provide geometry information to subsequent layouts. However it seems a bit odd to see LayoutState in the context of painting and hittesting (this is not new to this patch)
Comment 4 Simon Fraser (smfr) 2020-09-13 21:00:51 PDT 
Created attachment 408678 [details]
Patch
Comment 5 Simon Fraser (smfr) 2020-09-14 10:08:30 PDT 
Created attachment 408719 [details]
Patch
Comment 6 Simon Fraser (smfr) 2020-09-14 10:26:35 PDT 
Created attachment 408721 [details]
Patch
Comment 7 Simon Fraser (smfr) 2020-09-14 10:42:23 PDT 
Created attachment 408723 [details]
Patch
Comment 8 EWS 2020-09-14 11:26:32 PDT 
Committed r267024: <https://trac.webkit.org/changeset/267024>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 408723 [details].
Comment 9 Radar WebKit Bug Importer 2020-09-14 11:27:33 PDT 
<rdar://problem/68867274>
Comment 10 Darin Adler 2020-09-14 11:28:53 PDT 
Comment on attachment 408723 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408723&action=review

> Source/WebCore/layout/display/DisplayLayerController.h:52
> +    LayerController(View&);

explicit

> Source/WebCore/layout/display/DisplayView.h:52
> +    View(FrameView&);

explicit
Comment 11 Simon Fraser (smfr) 2020-09-14 11:40:24 PDT 
https://trac.webkit.org/changeset/267025/webkit