Bug 216466 – [LFC Display] First steps towards LFC painting in WebKit2

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Simon Fraser (smfr)]

First steps towards LFC painting in WebKit2

[Simon Fraser (smfr)]

Created attachment 408665 [details]
Patch

[Simon Fraser (smfr)]

Created attachment 408666 [details]
Patch

[zalan]

Comment on attachment 408666 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408666&action=review

> Source/WebCore/layout/display/DisplayLayerController.cpp:83
> +    if (!layoutState.hasDisplayBox(rootLayoutBox))
> +        return;

Shouldn't this be an ASSERT instead? We should never try to paint unless we have computed geometry (completed a layout).

> Source/WebCore/layout/display/DisplayView.cpp:89
> +

extra line

> Source/WebCore/layout/display/DisplayView.h:65
> +    // FIXME: Do we need to use LayoutTreeContent?

I really hope not.
I think we should figure out a way to have no dependency on LayoutState either. Display::Boxes are part of the state as they provide geometry information to subsequent layouts. However it seems a bit odd to see LayoutState in the context of painting and hittesting (this is not new to this patch)

[Simon Fraser (smfr)]

Created attachment 408678 [details]
Patch

[Simon Fraser (smfr)]

Created attachment 408719 [details]
Patch

[Simon Fraser (smfr)]

Created attachment 408721 [details]
Patch

[Simon Fraser (smfr)]

Created attachment 408723 [details]
Patch

[EWS]

Committed r267024: <https://trac.webkit.org/changeset/267024>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 408723 [details].

[Radar WebKit Bug Importer]

<rdar://problem/68867274>

[Darin Adler]

Comment on attachment 408723 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408723&action=review

> Source/WebCore/layout/display/DisplayLayerController.h:52
> +    LayerController(View&);

explicit

> Source/WebCore/layout/display/DisplayView.h:52
> +    View(FrameView&);

explicit

[Simon Fraser (smfr)]

https://trac.webkit.org/changeset/267025/webkit