Bug 216464 - Enable WebGL2 by default
Summary: Enable WebGL2 by default
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-13 12:36 PDT by Dean Jackson
Modified: 2020-09-14 12:09 PDT (History)
2 users (show)

See Also:


Attachments
Patch (5.30 KB, patch)
2020-09-13 12:43 PDT, Dean Jackson
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2020-09-13 12:36:08 PDT
Enable WebGL2 by default
Comment 1 Radar WebKit Bug Importer 2020-09-13 12:38:10 PDT
<rdar://problem/68811378>
Comment 2 Dean Jackson 2020-09-13 12:43:13 PDT
Created attachment 408662 [details]
Patch
Comment 3 Dean Jackson 2020-09-13 12:43:29 PDT
I think Sam or Anders should review this.
Comment 4 Sam Weinig 2020-09-13 12:45:09 PDT
Comment on attachment 408662 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408662&action=review

> Source/WebKit/Shared/WebPreferences.yaml:1461
>  WebGL2Enabled:
>    type: bool
> -  defaultValue: false
> +  defaultValue: true
>    humanReadableName: "WebGL 2.0"
>    humanReadableDescription: "WebGL 2 prototype"
>    category: experimental

Not that I actually understand the rules for experimental, but should this still be experimental if it is on by default?
Comment 5 Dean Jackson 2020-09-14 11:04:53 PDT
Comment on attachment 408662 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408662&action=review

>> Source/WebKit/Shared/WebPreferences.yaml:1461
>>    category: experimental
> 
> Not that I actually understand the rules for experimental, but should this still be experimental if it is on by default?

The original plan was that experimental features should be off by default, but people also wanted a way to toggle off features that were about to ship. Maybe we need yet another form of feature? "Candidate"?
Comment 6 Dean Jackson 2020-09-14 12:09:21 PDT
Committed r267027: <https://trac.webkit.org/changeset/267027>