Bug 216449 - Clean up AVKitSPI.h
Summary: Clean up AVKitSPI.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Peng Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-12 16:21 PDT by Peng Liu
Modified: 2020-09-14 18:27 PDT (History)
4 users (show)

See Also:

Attachments
Patch (10.50 KB, patch)
2020-09-12 16:33 PDT, Peng Liu 		no flags Details | Formatted Diff | Diff
Patch (10.41 KB, patch)
2020-09-12 16:53 PDT, Peng Liu 		no flags Details | Formatted Diff | Diff
Patch (10.21 KB, patch)
2020-09-14 09:37 PDT, Peng Liu 		no flags Details | Formatted Diff | Diff
Fix watchOS build failures (2.64 KB, patch)
2020-09-14 17:16 PDT, Peng Liu 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peng Liu 2020-09-12 16:21:07 PDT 
Clean up AVKitSPI.h
Comment 1 Peng Liu 2020-09-12 16:33:45 PDT 
Created attachment 408627 [details]
Patch
Comment 2 Peng Liu 2020-09-12 16:53:13 PDT 
Created attachment 408628 [details]
Patch
Comment 3 EWS 2020-09-13 14:17:39 PDT 
Committed r267004: <https://trac.webkit.org/changeset/267004>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 408628 [details].
Comment 4 Radar WebKit Bug Importer 2020-09-13 14:18:15 PDT 
<rdar://problem/68814026>
Comment 5 Peng Liu 2020-09-14 08:45:09 PDT 
Reverted r267004 for reason:

The patch leads to build failures on macOS Catalina

Committed r267013: <https://trac.webkit.org/changeset/267013>
Comment 6 Peng Liu 2020-09-14 09:37:41 PDT 
Created attachment 408715 [details]
Patch
Comment 7 Darin Adler 2020-09-14 11:00:31 PDT 
Comment on attachment 408715 [details]
Patch

You don’t need a new review in a case like this.
Comment 8 Peng Liu 2020-09-14 11:26:47 PDT 
(In reply to Darin Adler from comment #7)
> Comment on attachment 408715 [details]
> Patch
> 
> You don’t need a new review in a case like this.

Got it, thanks!
Comment 9 EWS 2020-09-14 14:40:41 PDT 
Committed r267041: <https://trac.webkit.org/changeset/267041>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 408715 [details].
Comment 10 Peng Liu 2020-09-14 16:56:42 PDT 
Reopen this bug to fix a build failure on watchOS.
Comment 11 Peng Liu 2020-09-14 17:16:42 PDT 
Created attachment 408767 [details]
Fix watchOS build failures
Comment 12 EWS 2020-09-14 18:27:26 PDT 
Committed r267063: <https://trac.webkit.org/changeset/267063>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 408767 [details].