Bug 216433 - [LFC][IFC] Add support for non-root-inline-box line spacing
Summary: [LFC][IFC] Add support for non-root-inline-box line spacing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-09-12 05:48 PDT by zalan
Modified: 2020-09-12 10:08 PDT (History)
5 users (show)

See Also:


Attachments
Patch (9.32 KB, patch)
2020-09-12 06:04 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (9.32 KB, patch)
2020-09-12 06:42 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (9.28 KB, patch)
2020-09-12 09:08 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (10.28 KB, patch)
2020-09-12 09:29 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (10.28 KB, patch)
2020-09-12 09:34 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2020-09-12 05:48:01 PDT
when the line spacing comes from a nested inline box.
Comment 1 zalan 2020-09-12 06:04:02 PDT
Created attachment 408591 [details]
Patch
Comment 2 zalan 2020-09-12 06:42:14 PDT
Created attachment 408592 [details]
Patch
Comment 3 Antti Koivisto 2020-09-12 09:05:47 PDT
Comment on attachment 408592 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=408592&action=review

> Source/WebCore/layout/inlineformatting/InlineLineBox.h:116
> +    using InlineBoxMap = HashMap<const Box*, InlineBox*>;
> +    const InlineBoxMap::ValuesConstIteratorRange inlineBoxList() const { return m_inlineBoxRectMap.values(); }

Maybe this can return 'auto' and void defining a type?
Comment 4 zalan 2020-09-12 09:08:54 PDT
Created attachment 408598 [details]
Patch
Comment 5 zalan 2020-09-12 09:09:33 PDT
(In reply to Antti Koivisto from comment #3)
> Comment on attachment 408592 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=408592&action=review
> 
> > Source/WebCore/layout/inlineformatting/InlineLineBox.h:116
> > +    using InlineBoxMap = HashMap<const Box*, InlineBox*>;
> > +    const InlineBoxMap::ValuesConstIteratorRange inlineBoxList() const { return m_inlineBoxRectMap.values(); }
> 
> Maybe this can return 'auto' and void defining a type?
Yeah, it works! It's so much better! Thanks.
Comment 6 zalan 2020-09-12 09:29:15 PDT
Created attachment 408599 [details]
Patch
Comment 7 zalan 2020-09-12 09:34:42 PDT
Created attachment 408600 [details]
Patch
Comment 8 EWS 2020-09-12 10:07:42 PDT
Committed r266978: <https://trac.webkit.org/changeset/266978>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 408600 [details].
Comment 9 Radar WebKit Bug Importer 2020-09-12 10:08:16 PDT
<rdar://problem/68769707>